Visitar URL original
feat: make tests run against environments other than prod by rsaksham · Pull Request #883 · googleapis/python-storage · GitHub
Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

feat: make tests run against environments other than prod - #883

Merged
gcf-merge-on-green[bot] merged 70 commits into
googleapis:mainfrom
rsaksham-dev:main_pr
Oct 21, 2022
Merged

feat: make tests run against environments other than prod#883
gcf-merge-on-green[bot] merged 70 commits into
googleapis:mainfrom
rsaksham-dev:main_pr

Conversation

@rsaksham

@rsaksham rsaksham commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

Made changes that override api endpoint information while triggering builds from kokoro .
All tests against prod are still successful.
Some system tests are currently incompatible with nonprod environments and hence are marked to be skipped if endpoint is being overriden.

@rsaksham
rsaksham requested review from a team October 7, 2022 16:54
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Oct 7, 2022
@rsaksham rsaksham changed the title Make tests run against environments other than prod feat: make tests run against environments other than prod Oct 10, 2022
andrewsg
andrewsg suggested changes Oct 13, 2022
View reviewed changes
Comment thread google/cloud/storage/blob.py Resolved
Comment thread .kokoro/build.sh Resolved
Comment thread google/cloud/storage/client.py Resolved
Comment thread tests/system/test__signing.py Resolved
Comment thread tests/system/test_bucket.py Resolved
Comment thread tests/system/test_client.py Resolved
andrewsg
andrewsg approved these changes Oct 17, 2022
View reviewed changes
Comment thread noxfile.py Resolved
@andrewsg andrewsg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 17, 2022
@rsaksham
Merge pull request #11 from googleapis/main
f6d3bff 
chore(deps): update dependency pandas to v1.5.1 (googleapis#889)
@andrewsg andrewsg added the automerge Merge the pull request once unit tests and other checks pass. label Oct 20, 2022
@gcf-merge-on-green

gcf-merge-on-green Bot commented Oct 20, 2022

Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 20, 2022
@rsaksham
Merge pull request #12 from googleapis/main
15623c4 
docs: streamline docs for c.g.c migration (googleapis#876)
@frankyn frankyn added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Oct 20, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 20, 2022
@gcf-merge-on-green
gcf-merge-on-green Bot merged commit 7dfeb62 into googleapis:main Oct 21, 2022
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 21, 2022
@release-please release-please Bot mentioned this pull request Oct 21, 2022
Merged
@parthea parthea mentioned this pull request Oct 22, 2022
Merged
@rsaksham
rsaksham deleted the main_pr branch December 8, 2022 10:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@andrewsg andrewsg andrewsg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rsaksham @andrewsg @frankyn @yoshi-kokoro