Visitar URL original
networking: Resolve TODO · gophercloud/gophercloud@650c511 · GitHub
Skip to content

Commit 650c511

Browse files
committed
networking: Resolve TODO
Change ListOpts.RevisionNumber to a *int. Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
1 parent e8be262 commit 650c511

1 file changed

Lines changed: 15 additions & 16 deletions

File tree

‎openstack/networking/v2/extensions/trunks/requests.go‎

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -64,22 +64,21 @@ type ListOptsBuilder interface {
6464
// by a particular trunk attribute. SortDir sets the direction, and is either
6565
// `asc' or `desc'. Marker and Limit are used for pagination.
6666
type ListOpts struct {
67-
AdminStateUp *bool `q:"admin_state_up"`
68-
Description string `q:"description"`
69-
ID string `q:"id"`
70-
Name string `q:"name"`
71-
PortID string `q:"port_id"`
72-
Status string `q:"status"`
73-
TenantID string `q:"tenant_id"`
74-
ProjectID string `q:"project_id"`
75-
SortDir string `q:"sort_dir"`
76-
SortKey string `q:"sort_key"`
77-
Tags []string `q:"tags" format:"comma-separated"`
78-
TagsAny []string `q:"tags-any" format:"comma-separated"`
79-
NotTags []string `q:"not-tags" format:"comma-separated"`
80-
NotTagsAny []string `q:"not-tags-any" format:"comma-separated"`
81-
// TODO change type to *int for consistency
82-
RevisionNumber string `q:"revision_number"`
67+
AdminStateUp *bool `q:"admin_state_up"`
68+
Description string `q:"description"`
69+
ID string `q:"id"`
70+
Name string `q:"name"`
71+
PortID string `q:"port_id"`
72+
Status string `q:"status"`
73+
TenantID string `q:"tenant_id"`
74+
ProjectID string `q:"project_id"`
75+
SortDir string `q:"sort_dir"`
76+
SortKey string `q:"sort_key"`
77+
Tags []string `q:"tags" format:"comma-separated"`
78+
TagsAny []string `q:"tags-any" format:"comma-separated"`
79+
NotTags []string `q:"not-tags" format:"comma-separated"`
80+
NotTagsAny []string `q:"not-tags-any" format:"comma-separated"`
81+
RevisionNumber *int `q:"revision_number"`
8382
}
8483

8584
// ToTrunkListQuery formats a ListOpts into a query string.

0 commit comments

Comments
 (0)