Visitar URL original
"create" filter button disabled · Issue #3348 · gorhill/uBlock · GitHub
Skip to content

"create" filter button disabled #3348

Open

Description

@mapx-
  • windows 10

  • FF 58.0b11 (64-bit) uBo 1.14.21rc4
    or

  • chrome Version 64.0.3282.24 (Official Build) beta (64-bit) uBo dev build 1.14.21.104

  • go to google.com

  • open dashboard, logger

  • refresh page

  • choose some element to block for example:
    notifications.google.com

  • Click on the 4th cell of a log entry => to create a static filter

  • create the filter => ||notifications.google.com

Now refresh the page, go into "my filters" tab, delete the filter.
Repeat exactly the same steps above.
When the filter was created exactly as in the first step => the "Create" button is disabled.

It does not matter which is the test page.

Activity

  1. mapx- commented on Dec 17, 2017

    @mapx-
    Author

    probably same root origin:

    • disable "my filters" list
    • use element picker to create a cosmetic filter
    • the filter is written in "my filters" section but should not apply (on refreshing page)
  2. gorhill commented on Jan 1, 2018

    @gorhill
    Owner

    Without looking into it, I think I remember keeping a list of the latest filters created through that UI, and disable the create button if there is an attempt to create the same filter again. I did not take into account that the user could delete the filter and re-create again. I need a better approach to prevent creating duplicate filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions