Visitar URL original
Run all cross-version targets in flaky quarantine · gradle/gradle@66805db · GitHub
Skip to content

Commit 66805db

Browse files
blindpiratecobexer
blindpirate
authored and
cobexer
committed
Run all cross-version targets in flaky quarantine
PR #39110 pointed the AllVersionsCrossVersion quarantine at quickFeedbackCrossVersionTest to cut its runtime. That makes the coverage a duplicate: QuickFeedbackCrossVersion quarantines already exist for Linux and Windows on the same MIN_VERSION JVM, so the two pairs of builds run an identical task set. It also drops the target list from one per minor release to one per major, in the only build that runs @flaky cross-version tests at all -- and a cross-version test is quarantined precisely because its behaviour is target dependent in some way we do not understand yet. The cost problem is now handled by the other half of #39110: with DetectFlakyTests skipping the empty test tasks, the full allVersionsCrossVersionTest quarantine fits on a single agent inside the 240 minute timeout. (cherry picked from commit 2878591)
1 parent cdd4c8f commit 66805db

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

‎.teamcity/src/main/kotlin/configurations/FlakyTestQuarantine.kt‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -128,13 +128,9 @@ class FlakyTestQuarantine(
128128
gradleWrapper {
129129
name =
130130
"FLAKY_TEST_QUARANTINE_${testCoverage.testType.name.uppercase()}_${testCoverage.testJvmVersion.name.uppercase()}"
131-
// Each cross-version target costs minutes to fork a JVM and unpack the distribution under
132-
// test. Whether a test still flakes does not depend on which patch release it runs against,
133-
// so the quarantine takes the one target per major that quickFeedbackCrossVersionTest covers.
134131
val testTaskName =
135132
when (testCoverage.testType) {
136133
TestType.ISOLATED_PROJECTS -> "isolatedProjectsIntegTest"
137-
TestType.ALL_VERSIONS_CROSS_VERSION -> "quickFeedbackCrossVersionTest"
138134
else -> "${testCoverage.testType.asCamelCase()}Test"
139135
}
140136
tasks = "clean $testTaskName"

0 commit comments

Comments
 (0)