Visitar URL original
UI: `context-create` component should suggest `-server-tls-skip-verify` flag · Issue #3110 · hashicorp/waypoint · GitHub
Skip to content
This repository was archived by the owner on Jan 8, 2024. It is now read-only.
This repository was archived by the owner on Jan 8, 2024. It is now read-only.

UI: context-create component should suggest -server-tls-skip-verify flag #3110

Open
Open
UI: context-create component should suggest -server-tls-skip-verify flag#3110
Assignees
gregone
Labels
good first issueGood for newcomersui

Description

@smaeda-ks
smaeda-ks
opened on Mar 17, 2022

Is your feature request related to a problem? Please describe.

https://github.com/hashicorp/waypoint/blob/main/ui/app/components/context-create/index.hbs

The current UI context-create component doesn't care about the environment that the server runs on. Therefore, during development/testing where the hostname is localhost (127.0.0.1), the suggested CLI command won't create the desired context unless the -server-tls-skip-verify flag is set to true along with it.
Otherwise, subsequent waypoint commands would result in the context deadline exceeded error.

Describe the solution you'd like

There is unlikely a heuristic way to catch all scenarios nicely given the hostname is just taken by the window.location.hostname value. Always include or only include if the hostname is localhost by the conditional rendering is an easy workaround but might not be an ideal approach.

Activity

  1. smaeda-ks
    added
    new
    ui
    on Mar 17, 2022
  2. xiaolin-ninja
    added
    good first issueGood for newcomers
    and removed
    new
    on Mar 23, 2022

  3. xiaolin-ninja commented on Mar 23, 2022

    @xiaolin-ninja
    xiaolin-ninja
    on Mar 23, 2022
    Contributor

    This code is out of date, we'll get on fixing it. Thanks!

  4. xiaolin-ninja
    assigned
    gregone
    on Mar 23, 2022
  5. gregone
    added this to the 0.8.y milestone on Mar 24, 2022
  6. krantzinator
    removed this from the 0.9.y milestone on Jul 13, 2022

  7. jgwhite commented on Jul 21, 2022

    @jgwhite
    jgwhite
    on Jul 21, 2022
    Contributor

    We could/should use GetServerConfig to inform this UI.

    The ServerConfig.advertise_addrs field even includes a hint as to whether or not to skip TLS verification:

    message AdvertiseAddr {
  string addr = 1;
  bool tls = 2;
  bool tls_skip_verify = 3; // <---
}

    Note that ServerConfig.advertise_addrs can be nil1 in which case maybe we could fall back to existing window.location logic with -server-skip-tls-verify on by default.

    Footnotes

    1. It is when you boot the server with waypoint server run, for example ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

good first issueGood for newcomersui

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions