Visitar URL original
NonEmptySet.delete doesn't delete element · Issue #12570 · haskell/cabal · GitHub
Skip to content

NonEmptySet.delete doesn't delete element #12570

New issue
New issue
Open
#12571
Open
NonEmptySet.delete doesn't delete element#12570
#12571
Labels
attention: pr-welcometype: bug

Description

@philderbeast
philderbeast
opened on Nov 11, 2026

There's an error in the implementation of NonEmptySet.delete, it behaves like id when the element is in the set.

cabal/Cabal-syntax/src/Distribution/Compat/NonEmptySet.hs

Lines 98 to 103 in 90fa465

delete :: Ord a => a -> NonEmptySet a -> Maybe (NonEmptySet a)
delete x (NES xs)
| Set.null res = Nothing
| otherwise = Just (NES xs)
where
res = Set.delete x xs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    attention: pr-welcometype: bug

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions