Repository navigation
Behavior of getHomeDirectory and/or canonicalizePath is inconsistent across GHC versions #44
Description
Here is the test:
https://github.com/mrkkrp/path-io/blob/master/tests/Main.hs#L116
It succeds with 7.10, but fails with 7.8 and 8.0:
https://travis-ci.org/mrkkrp/path-io/jobs/110565920#L381
At first I decided to “forgive” 7.8 and added some CPP to skip that test there, but now I added 8.0 to build matcix and this thing again throws something unexpected. getHomeDir uses getHomeDirectory and canonicalizePath, so the only thing it can throw in the setting of that test is isDoesNotExistError. Any comment?
Activity
Rufflewind commentedon Feb 20, 2016
canonicalizePathused to have unpredictable behavior on non-existent paths in versions ofdirectoryolder than 1.2.3.0. Since 1.2.3.0, it was fixed to return a sensible result for any path, even non-existent ones. Hence, your test should expect no errors at all, but only ifdirectoryis 1.2.3.0 or newer. Otherwise, all bets are off.Keep in mind that the version of
directoryis not tied to that of GHC orbase. Consider checking fordirectory's version rather thanbase:#if MIN_VERSION_directory(1, 2, 3)Your Travis tests for GHC 7.8 pulled in directory-1.2.5.0, but for GHC 7.10 it was using directory-1.2.2.0.
mrkkrp commentedon Feb 20, 2016
Thanks for the explanation, I will update the tests accordingly.
Remove tests with unpredictable behavior
Improve file and directory resolution
haskell#44, isValid \0 now returns False
haskell#44, clarify that isValid doesn't check length limits
Workaround for exception-throwing canonicalizePath in old directory