Repository navigation
Closed
Labels
A-BUGSomething wrong, confusing or sub-standard in the software, docs, or user experience.Something wrong, confusing or sub-standard in the software, docs, or user experience.balancebountyThar's some kind o' loot on offer..Thar's some kind o' loot on offer..budgetThe balance command's --budget reportThe balance command's --budget reportdocsDocumentation-related.Documentation-related.incomestatementregressionA backwards step, indicating a weakness in our QA. We don't like these.A backwards step, indicating a weakness in our QA. We don't like these.
Description
From the docs it appears that incomestatement should take the --budget command, like balance. But I don't see that happening (hledger 1.41, mac-aarch64):
> hledger bal --budget -M
Budget performance in 2024-11-01..2024-12-31:
|| Nov Dec
===========================++================================================================
...
expenses || £36.00 [1% of £2,453.22] £3,071.67 [ 125% of £2,453.22]
expenses:bills || £36.00 [7% of £532.22] £384.67 [ 72% of £532.22]
...
---------------------------++----------------------------------------------------------------
|| 0 [ 0] 0 [ 0]
> hledger is --budget -M
Monthly Income Statement 2024-11-01..2024-12-31
|| Nov Dec
===========================++=====================
Revenues ||
---------------------------++---------------------
...
---------------------------++---------------------
|| 0 £633.51
===========================++=====================
Expenses ||
---------------------------++---------------------
expenses:bills || £36.00 £384.67
...
---------------------------++---------------------
|| £36.00 £3,071.67
===========================++=====================
Net: || £-36.00 £-2,438.16
(I've removed most of the lines, but the point is that is doesn't show the square bracketed numbers and percentages).
Metadata
Metadata
Assignees
Labels
A-BUGSomething wrong, confusing or sub-standard in the software, docs, or user experience.Something wrong, confusing or sub-standard in the software, docs, or user experience.balancebountyThar's some kind o' loot on offer..Thar's some kind o' loot on offer..budgetThe balance command's --budget reportThe balance command's --budget reportdocsDocumentation-related.Documentation-related.incomestatementregressionA backwards step, indicating a weakness in our QA. We don't like these.A backwards step, indicating a weakness in our QA. We don't like these.
Activity
simonmichael commentedon Dec 17, 2024
Thanks for the report. But
--budgetis only supported by thebalancecommand at present. Which docs made you think otherwise ?lowercasename commentedon Dec 17, 2024
The section here: https://hledger.org/1.41/hledger.html#incomestatement
Have I misread the docs somehow?
lowercasename commentedon Dec 17, 2024
I get the same with the
--helpflag on the command line:simonmichael commentedon Dec 17, 2024
You've read them right, that does seem like a bug.
Flags listed under "General * flags" headings are not expected to have an effect with all commands, which sometimes surprises people.
But here it's in the command-specific "Flags" section, which is definitely wrong. This changed in hledger-1.21. Thanks!
I'll either remove the flag, or (better ?) someone could add --budget support to incomestatement. I'm not sure how big or small a task that is.
Does this qualify for https://hledger.org/REGRESSIONS.html#regression-bounty ? One or two bounties have been granted for 0.21, so I think yes. Please claim your $50 regression finder's bounty!
simonmichael commentedon Dec 17, 2024
Yes I see, perfectly valid finder's bounty. I'll clarify that page a bit.
lowercasename commentedon Dec 17, 2024
Oh wonderful, this has made my evening - I didn't realise there was a bug bounty! I'd love to add
--budgetsupport toincomestatementbut probably not as a Haskell novice - something to work towards perhaps.Thank you for making hledger, I've been really enjoying it.
fix:bs/bse/cf/is: drop unsupported --budget option from help [#2302]
simonmichael commentedon Dec 20, 2024
Dropped the --budget option from bs/bse/cf/is commands.
[-]--budget doesn't do anything with incomestatement[/-][+]1.21: --budget doesn't do anything with incomestatement[/+]