Visitar URL original
feat: add events api exception message by subzero10 · Pull Request #213 · honeybadger-io/honeybadger-php · GitHub
Skip to content

feat: add events api exception message - #213

Merged
subzero10 merged 2 commits into
masterfrom
events-api-exception-message-210
Nov 1, 2024
Merged

subzero10 merged 2 commits into
masterfrom
events-api-exception-message-210

Conversation

@subzero10

@subzero10 subzero10 commented Nov 1, 2024 •

Copy link
Copy Markdown
Member

Status

READY

Description

Closes #210.

Todos

  • Tests

@subzero10 subzero10 self-assigned this Nov 1, 2024
@subzero10
subzero10 requested a review from stympy November 1, 2024 15:48
@stympy

stympy commented Nov 1, 2024

Copy link
Copy Markdown
Member

There is more than one possible exceptional response. The non-201 responses are as follows:

  • 403 - Unauthorized (the API key is invalid or Insights ingestion has been disabled)
  • 422 - The payload could not be processed, either because it is malformed or because it is too large
  • 429 - The daily quota has been exceeded

@subzero10

Copy link
Copy Markdown
Member Author

There is more than one possible exceptional response. The non-201 responses are as follows:

  • 403 - Unauthorized (the API key is invalid or Insights ingestion has been disabled)
  • 422 - The payload could not be processed, either because it is malformed or because it is too large
  • 429 - The daily quota has been exceeded

We have all of those already, but are shared between errors api and events api.
This PR introduces separate messages for the 429 code.
events api:

  • You have hit your events rate limit.

errors api (this one already existed):

  • You have hit your exception rate limit.

You can take a look at all of them here.

@stympy

stympy commented Nov 1, 2024

Copy link
Copy Markdown
Member

Got it, thanks.

@subzero10
subzero10 merged commit e0a0b90 into master Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new exception messages when throwing exceptions for the events api

2 participants