Repository navigation
Cache/Queue metrics should not be negative #2495
Description
In the cache metrics collection, we have entries like:
{ _id: ObjectId("65d60409acf7b3719825797e"),
error_code: 'PreviousStepStillProcessingError',
http_status: 500,
kind: 'split-duckdb-index-010',
total: -67 }
The total should never be lower than 0
Activity
[-]Cache metrics should not be negative[/-][+]Cache/Queue metrics should not be negative[/+]Michal-Okularczyk commentedon May 27, 2025
I would like to work on this bug if that's ok!
#self-assign
ArjunJagdale commentedon Jul 1, 2025
Hi @severo! can I work on this issue??
ArjunJagdale commentedon Jul 1, 2025
Hi @severo — I think the metric write logic in collect_cache_metrics(), and will clamp total with max(total, 0) before calling
.upsert_one()to prevent storing negative values.The total comes from
get_responses_count_by_kind_status_and_error_code(), which might be worth auditing separately — but this fix will ensure DB consistency for now.Will raise the PR shortly — thanks again!
ArjunJagdale commentedon Aug 4, 2025
I have done a PR! just want your confirmation/thoughts..