Visitar URL original
use the `ROW_IDX_COLUMN` constant name instead of copying the value everywhere · Issue #2798 · huggingface/dataset-viewer · GitHub
Skip to content

use the ROW_IDX_COLUMN constant name instead of copying the value everywhere #2798

Open
Open
use the ROW_IDX_COLUMN constant name instead of copying the value everywhere#2798
Assignees
devesh-2002
Labels
P2Nice to havegood first issueGood for newcomersrefactoring / architecture

Description

@severo
severo
opened on May 13, 2024

dataset-viewer/libs/libapi/src/libapi/response.py

Line 13 in 3e4f278

ROW_IDX_COLUMN = "__hf_index_id"

See the occurrences:

https://github.com/search?q=repo%3Ahuggingface%2Fdataset-viewer+__hf_index_id&type=code

Maybe do the same for __hf_fts_score too, and move the values to constants.py?

Activity

  1. severo
    added
    good first issueGood for newcomers
    refactoring / architecture
    P2Nice to have
    on May 13, 2024
  2. severo
    changed the title [-]nit: use the `ROW_IDX_COLUMN` constant name instead of copying the value everywhere[/-] [+]use the `ROW_IDX_COLUMN` constant name instead of copying the value everywhere[/+] on May 13, 2024

  3. devesh-2002 commented on May 13, 2024

    @devesh-2002
    devesh-2002
    on May 13, 2024
    Contributor

    May I take this issue?

  4. severo
    assigned
    devesh-2002
    on May 13, 2024

  5. severo commented on May 13, 2024

    @severo
    severo
    on May 13, 2024
    ContributorAuthor

    Sure! I just assigned you the issue. Please ping me when your PR is ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Nice to havegood first issueGood for newcomersrefactoring / architecture

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions