Repository navigation
import/enforce-node-protocol-usage broken #3173
Description
The rule import/enforce-node-protocol-usage is not working with code containing the export keyword.
How to reproduce:
- Install
@jirimoravcik/eslint-plugin-importwith version2.32.0-beta.0as the rule was merged after2.31.0was released. - Do
'import/enforce-node-protocol-usage': ['error', 'always'],in your eslint config - Create a TS file with the following content:
export class Thing {
constructor(public readonly name: string) {
// Do nothing.
}
public sayHello(): void {
console.log(`Hello, ${this.name}!`);
}
}- Try to lint it
- You'll get an error:
TypeError: Cannot read properties of null (reading 'type')
Rule: "import-fixed/enforce-node-protocol-usage"
at checkAndReport (/Users/jirimoravcik/.../node_modules/@jirimoravcik/eslint-plugin-import/lib/rules/enforce-node-protocol-usage.js:47:11)
I fixed by doing an early return in jirimoravcik@272d471, but I'm not sure if that's the proper solution.
Thanks for looking into it.
Activity
ljharb commentedon Apr 10, 2025
I'm confused, why are you installing
@jirimoravcik/eslint-plugin-import? that's not this repo, and we can't support anything not installed fromeslint-plugin-importon npm.That said, I can reproduce it, and I've fixed it in the next version.
ljharb commentedon Apr 10, 2025
Fixed in da5f6ec
JounQin commentedon Apr 10, 2025
I believe that's because the latest codes has not been released.
ljharb commentedon Apr 10, 2025
Sure - but that also means a) don't use it yet, and b) install from this repo, not a fork
Update dependency eslint-plugin-import to v2.32.0