Repository navigation
Deprecate EventLogRecord#getEventId in favor of #getInstanceId - #1105
Conversation
61e6661 to
ee4c606
Compare
|
We don't seem to have tests for these, but maybe we can make some assumptions about the values returned from these methods in https://github.com/java-native-access/jna/blob/cc1acdac02e4d0dda93ba01bbe3a3435b8933dab/contrib/platform/test/com/sun/jna/platform/win32/Advapi32UtilTest.java? Ideally I'd want tests to describe something similar to http://balazsberki.com/2017/02/reading-the-windows-event-log-event-id-problems-with-qualifiers/ in. Merge on 🍏 either way. |
|
I think I can throw something together with some well-known ID types, e.g, event log started (6005) will be an info type with Instance ID -2147477643 (technically the positive value). Actually that brings up another question: in .NET the Instance ID is a 64-bit number. Should we make that a |
|
So I just added a test to search for the "Event Log started" event in the system log. But I also notided in |
|
👍 |
The terms "Event ID" and "event identifier" refer to different things, which leads to confusion and probably led to .NET deprecating the former term. JNA should do the same.