Memory.dispose() does not remove "this" from the allocatedMemory map #697

Activity

1. twall commented on Aug 30, 2016

   

   twall

   on Aug 30, 2016

   Contributor

   More actions

   Good catch. Could you provide a PR with the fix and an associated test?

   On Tue, Aug 30, 2016 at 3:33 AM, AgnetaWalterscheidt <
   notifications@github.com> wrote:

   Method Memory.dispose() frees the peer and sets it to 0. Afterwards it
   calls allocatedMemory.remove(this). This call does not find the Memory in
   the map: Memory is a subclass of Pointer which uses the peer for hashcode()
   and equals() and therefore "this" is no longer equal to the Memory that was
   put in the map.
   This bug is easy to fix by first calling allocatedMemory.remove(this) and
   then setting the peer to 0.

   —
   You are receiving this because you are subscribed to this thread.
   Reply to this email directly, view it on GitHub
   #697, or mute the thread
   https://github.com/notifications/unsubscribe-auth/AAuMrTUjJYafXGniw4wqiEDHC1hud0XGks5qk9y0gaJpZM4JwOmU
   .
2. matthiasblaesing

   added a commit that references this issue on Oct 10, 2016

   Ensure disposed memory is removed from Memory#allocatedMemory map

   ...

   This issue will close once commit b31240f is merged into the 'master' branch.

   b31240f
3. matthiasblaesing

   closed this as completedin #715on Oct 12, 2016
4. mstyura

   added a commit that references this issue on Sep 9, 2024

   Fix visibility of abstract methods (java-native-access#697)

   ...

   acfbcfe