Visitar URL original
Expose Database/PostgreSQL/Simple/Internal/PQResultUtils.hs · Issue #243 · lpsmith/postgresql-simple · GitHub
Skip to content

Expose Database/PostgreSQL/Simple/Internal/PQResultUtils.hs #243

Open

Description

@charles-cooper

This is a request to expose the functionality of Database.PostgreSQL.Simple.Internal.PQResultUtils. Similarly to Database.PostgreSQL.Simple.Internal, it doesn't need to be a stable API but it would really help external writers implement their own versions of query which can have slightly different hooks than postgresql-simple does without reimplementing (or copy/pasting!) the contents of PQResultUtils.hs.

For instance, a caching mechanism can be implemented by checking if a query is in the cache, and if so running the specified parser on the cached result bytes. It would be more maintainable if it could rely on postgresql-simple's well-developed parsing infrastructure instead of reimplementing it.

Another example is if somebody wanted to implement a binary client, they could simply write new binary parsers but still reuse postgresql-simple's Connection and result handling infrastructure.

I can submit a PR for this if it sounds acceptable

Activity

  1. changed the title [-]Expose `Database.PostgreSQL.Simple.Internal.PQResultUtils`[/-] [+]Expose Database/PostgreSQL/Simple/Internal/PQResultUtils.hs[/+] on Dec 30, 2017
  2. lpsmith commented on Aug 13, 2018

    @lpsmith
    Owner

    Sounds fine to me. (Sorry for the delay)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions