Repository navigation
Fix all initialism errors in the codebase #16623
Description
Summary
This ticket is about fixing any variable naming issues that do not follow the initialism convention as laid out in: https://github.com/golang/go/wiki/CodeReviewComments#initialisms.
The way to go about it would be to make the following change to .golangci.yml
diff --git a/.golangci.yml b/.golangci.yml
index 29d9a4622..662931923 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -49,7 +49,7 @@ issues:
- linters:
- golint
- text: "should have|should be|should replace|stutters|underscore|annoying|error strings should not be capitalized"
+ text: "should replace|stutters|underscore|annoying|error strings should not be capitalized"
- linters:
- golint And then fix all issues that arise until make golangci-lint passes with no errors.
Activity
simoncampion commentedon Jan 4, 2021
I'd like to work on this.
agnivade commentedon Jan 4, 2021
All yours @SimonSimonB !
agnivade commentedon Feb 5, 2021
Reopening this is not yet fully fixed.
haardikdharma10 commentedon Feb 5, 2021
Hi @agnivade, I have managed to fix few of the errors (Mainly in
/utils). Can I open a draft PR?agnivade commentedon Feb 6, 2021
You are most welcome to do that. But ensure to coordinate with @SimonSimonB so that work is not duplicated. :)
Merge branch 'master' into Fix-mattermost#16623
Merge branch 'master' into Fix-mattermost#16623
Merge branch 'master' into Fix-mattermost#16623
31 remaining items
drashtiv03 commentedon Apr 7, 2025
Hey @amyblais! I would like to work on this issue. Could you please assign it to me?
art1-code commentedon Nov 17, 2025
Hi! Is this issue still open for contribution, @amyblais ? If so, I’d like to work on it . Will be my first contribution.
amyblais commentedon Nov 17, 2025
@art1-code 👍
art1-code commentedon Nov 17, 2025
Hi @amyblais, I identified the following line in the .golangci.yml:
- linters: - revive text: var-naming|error-naming|exported|increment-decrement|error-strings|if-return|unused-parameter|blank-imports|empty-blockIt seems that revive is explicitly ignoring var-naming, which also suppresses initialism errors.
To work on this issue, would it be acceptable for me to temporarily remove var-naming from this exclusion so I can properly surface and fix the initialism warnings?
amyblais commentedon Nov 18, 2025
Hi @art1-code, I'm not a developer and I won't be able to adequately answer the question. Please come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.
hanzei commentedon Nov 18, 2025
Yes @art1-code that approach is fine 👍
art1-code commentedon Nov 24, 2025
I had some issues (just as expected) with the golangci-lint version, but i resolved them and now i'm working on the solution.