Unable to find manifest for extracted plugin when using make deploy

Summary

Unable to find manifest for extracted plugin error when using make deploy on M1 mac - no issue when deploying from Intel based Mac.

Steps to reproduce

Run make deploy on any Mattermost plugin (issue using starter template as well).

Build Succeeds
Plugin upload fails

Expected behavior

Plugin should upload and enable as usual.

Observed behavior (that appears unintentional)

Unable to find manifest for extracted plugin error when using make deploy.

Possible fixes

I can deploy normally from an Intel based machine.

@disco-panda

Hi @disco-panda, Would you be open to posting about this either on our Peer-to-peer Help channel or our Developers channel? One of our devs or community members will likely be able to help troubleshoot this issue.

@amyblais

@amyblais I have posted in both channels and have yet to have significant support, only a message from someone else having a similar problem.

@mickmister

@mickmister @trilopin Would you be able to help with this?

I have tried it on a variety of publicly available plugins including the ms-teams and github plugins, all succeed building but fail with the same error message -

Failed: failed to upload plugin bundle: : Unable to find manifest for extracted plugin., open /tmp/plugintmp2035330948/plugin.json: no such file or directory

Usage:
    pluginctl deploy <plugin id> <bundle path>
    pluginctl disable <plugin id>
    pluginctl enable <plugin id>
    pluginctl reset <plugin id>
make: *** [deploy] Error 1```

@disco-panda

Hi @disco-panda, thanks for reporting this issue.

Unable to find manifest for extracted plugin., open /tmp/plugintmp2035330948/plugin.json: no such file or director

error when using make deploy on M1 mac - no issue when deploying from Intel based Mac.

This error is pretty strange. I'm also using M1 Mac and haven't experienced this error before.

It's possible there is something going on with permissions to access files in your /tmp folder. Seems like it may be a lack of read permissions for the user used to run MM, since I would expect the initial write would fail if it was a write permission issue. @hanzei Any ideas on this?

@mickmister

Hey @mickmister, thanks for the response. Really appreciate the help trying to figure this out. It's a strange error for sure, and one that I only recently began experiencing.

When I build using an Intel based Mac, I have no issues deploying the plugin. Plugin deployment for both goes to same Docker container running in ECS which makes me think it is something happening locally on my M1 machine. I tried on a different M1 mac and had the same issue.

I have tried downgrading go to 1.18, I have tried setting my node version to 12, 16.13.1, and 18 - all with the same result.

I have encountered the same error while uploading the mattermost-plugin-cloud plugin. I have debugged a bit and found a possible cause for this error.

While I upload the plugin, It extracts the tar file in a directory.

total 8
drwx------@   4 mir  staff   128 Apr  8 02:20 .
drwx------@ 260 mir  staff  8320 Apr  8 02:20 ..
-rwxr-xr-x@   1 mir  staff   163 Apr  8 02:20 ._com.mattermost.cloud
drwxr--r--@  12 mir  staff   384 Apr  8 02:20 com.mattermost.cloud

This ._com.mattermost.cloud file is not supposed to be here. The code is expecting only one file.

In my case, the plugin.json file is inside the com.mattermost.cloud folder.

Solution

tar -cvzf command creates ._ files to store extended attributes. You need to tell tar to remove the metadata by setting COPYFILE_DISABLE

So run COPYFILE_DISABLE=1 tar -cvzf to make tar file to upload as plugin.

@mirshahriar

@mirshahriar Well look at that, this one simple fix solved my issue - fantastic! Thank you so much for your help.

I see that you have opened a PR to address and it has been approved so I will close this issue.

While mattermost/mattermost-plugin-cloud#119 solves the issue for the Cloud plugin, the server code should be more forgiving when it comes to extra files. If anyone from the community is interested in relaxing the rules to fix the issue holistically, they are more then welcome.

@disco-panda

Hello @disco-panda can i work on this issue ?

@shubmjagtap

Sure @shubmjagtap, please let me know if you are running into any issues.

this issue is related to Mac ( operating system ) im not using Mac , so I think im not eligible to solve this issue

I unassign myself , thankyou.

But accordiing to you if you think as non Mac user , im eligible to solve this issue then please reassign it to me , i will be happy to solve it

As you said, it's a Mac specific issue, it doesn't make sense for non-mac user to work on it.

ok

Please take a look at the other tickets that are available.

fix: tar bundle error on mac silicon

Navigation Menu

Repository navigation

`Unable to find manifest for extracted plugin` when using `make deploy` #22614

Summary

Steps to reproduce

Expected behavior

Observed behavior (that appears unintentional)

Possible fixes

Solution

15 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Unable to find manifest for extracted plugin when using make deploy #22614

Description

Summary

Steps to reproduce

Expected behavior

Observed behavior (that appears unintentional)

Possible fixes

Activity

amyblais commented on Mar 23, 2023

disco-panda commented on Apr 4, 2023

amyblais commented on Apr 4, 2023

disco-panda commented on Apr 4, 2023

mickmister commented on Apr 4, 2023

disco-panda commented on Apr 5, 2023

mirshahriar commented on Apr 7, 2023

Solution

disco-panda commented on Apr 10, 2023

hanzei commented on Apr 11, 2023

15 remaining items

shubmjagtap commented on Aug 10, 2023

hanzei commented on Aug 11, 2023

shubmjagtap commented on Aug 11, 2023

shubmjagtap commented on Aug 11, 2023

shubmjagtap commented on Aug 11, 2023

hanzei commented on Aug 11, 2023

shubmjagtap commented on Aug 11, 2023

hanzei commented on Aug 11, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

`Unable to find manifest for extracted plugin` when using `make deploy` #22614