Visitar URL original
Adds complex layout impeller startup benchmark (#183655) · mboetger/flutter@b3b7172 · GitHub
Skip to content

Commit b3b7172

Browse files
gaaclarkegemini-code-assist[bot]
authored and
mboetger
committed
Adds complex layout impeller startup benchmark (flutter#183655)
issue flutter#183041 fixes flutter#183035 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1 parent 34f23f3 commit b3b7172

5 files changed

Lines changed: 35 additions & 3 deletions

File tree

‎.ci.yaml‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3817,6 +3817,18 @@ targets:
38173817
tags: >
38183818
["framework", "hostonly", "shard", "mac"]
38193819
3820+
- name: Mac_benchmark complex_layout_macos_impeller__start_up
3821+
presubmit: false
3822+
recipe: devicelab/devicelab_drone
3823+
bringup: true
3824+
timeout: 60
3825+
properties:
3826+
dependencies: >-
3827+
[
3828+
{"dependency": "ruby", "version": "ruby_3.1-pod_1.13"}
3829+
]
3830+
task_name: complex_layout_macos_impeller__start_up
3831+
38203832
- name: Mac_benchmark complex_layout_macos__start_up
38213833
presubmit: false
38223834
recipe: devicelab/devicelab_drone

‎TESTOWNERS‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,7 @@
251251
/dev/devicelab/bin/tasks/build_ios_framework_module_test.dart @vashworth @flutter/tool
252252
/dev/devicelab/bin/tasks/channels_integration_test_macos.dart @gaaclarke @flutter/desktop
253253
/dev/devicelab/bin/tasks/complex_layout_macos__compile.dart @cbracken @flutter/desktop
254+
/dev/devicelab/bin/tasks/complex_layout_macos_impeller__start_up.dart @gaaclarke @flutter/desktop
254255
/dev/devicelab/bin/tasks/complex_layout_macos__start_up.dart @cbracken @flutter/desktop
255256
/dev/devicelab/bin/tasks/complex_layout_scroll_perf_macos__timeline_summary.dart @cbracken @flutter/desktop
256257
/dev/devicelab/bin/tasks/complex_layout_win_desktop__compile.dart @yaakovschectman @flutter/desktop

‎dev/devicelab/bin/tasks/complex_layout_macos__start_up.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,5 @@ import 'package:flutter_devicelab/tasks/perf_tests.dart';
88

99
Future<void> main() async {
1010
deviceOperatingSystem = DeviceOperatingSystem.macos;
11-
await task(createComplexLayoutStartupTest());
11+
await task(createComplexLayoutStartupTest(enableImpeller: false));
1212
}

‎dev/devicelab/bin/tasks/complex_layout_macos_impeller__start_up.dart‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
// Copyright 2014 The Flutter Authors. All rights reserved.
2+
// Use of this source code is governed by a BSD-style license that can be
3+
// found in the LICENSE file.
4+
5+
import 'package:flutter_devicelab/framework/devices.dart';
6+
import 'package:flutter_devicelab/framework/framework.dart';
7+
import 'package:flutter_devicelab/tasks/perf_tests.dart';
8+
9+
Future<void> main() async {
10+
deviceOperatingSystem = DeviceOperatingSystem.macos;
11+
await task(createComplexLayoutStartupTest(enableImpeller: true));
12+
}

‎dev/devicelab/lib/tasks/perf_tests.dart‎

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -283,8 +283,11 @@ TaskFunction createFlutterGalleryStartupTest({
283283
).run;
284284
}
285285

286-
TaskFunction createComplexLayoutStartupTest() {
287-
return StartupTest('${flutterDirectory.path}/dev/benchmarks/complex_layout').run;
286+
TaskFunction createComplexLayoutStartupTest({bool? enableImpeller}) {
287+
return StartupTest(
288+
'${flutterDirectory.path}/dev/benchmarks/complex_layout',
289+
enableImpeller: enableImpeller,
290+
).run;
288291
}
289292

290293
TaskFunction createFlutterGalleryCompileTest() {
@@ -937,12 +940,14 @@ class StartupTest {
937940
this.runEnvironment,
938941
this.enableLazyShaderMode = false,
939942
this.enableHcpp = false,
943+
this.enableImpeller,
940944
});
941945

942946
final String testDirectory;
943947
final bool reportMetrics;
944948
final bool enableLazyShaderMode;
945949
final bool enableHcpp;
950+
final bool? enableImpeller;
946951
final String target;
947952
final Map<String, String>? runEnvironment;
948953

@@ -1062,6 +1067,8 @@ class StartupTest {
10621067
'-d',
10631068
device.deviceId,
10641069
if (applicationBinaryPath != null) '--use-application-binary=$applicationBinaryPath',
1070+
if (enableImpeller != null && enableImpeller!) '--enable-impeller',
1071+
if (enableImpeller != null && !enableImpeller!) '--no-enable-impeller',
10651072
],
10661073
environment: runEnvironment,
10671074
canFail: true,

0 commit comments

Comments
 (0)