Repository navigation
Commit 6453d64
committed
fix(test): serialize core build in build-theme.variants through the shared lock
build-theme.variants.test.mjs was the one build-theme suite still running
its own unguarded 'if (!exists) pnpm -F core build' in beforeAll instead
of the ensureCoreBuilt() lock helper that exists precisely because
concurrent core builds collide on packages/core/dist (the build starts
by wiping dist).
The ui/node project split changed file scheduling so the build-theme
suites start near-simultaneously on fresh-checkout CI, which made the
latent race fire: variants' unlocked build ran concurrently with the
lock-holder's build, dist was wiped mid-suite, and the CLI under test
exited 1 on missing core .d.ts files ('expected 1 to be +0' in CI run
29151203513, while the first two tests of the same suite passed).
Verified by deleting packages/core/dist and running all four build-theme
suites concurrently in the node project — all pass with the build
serialized behind the lock.1 parent 1a85712 commit 6453d64
1 file changed
Lines changed: 7 additions & 18 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | 35 | | |
46 | 36 | | |
47 | 37 | | |
| |||
68 | 58 | | |
69 | 59 | | |
70 | 60 | | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
71 | 66 | | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
| 67 | + | |
79 | 68 | | |
80 | 69 | | |
81 | 70 | | |
| |||
0 commit comments