Visitar URL original
fix: refactor ToIdentifier() to normalize flaggable enums by MaggieKimani1 · Pull Request #2156 · microsoft/OpenAPI.NET · GitHub
Skip to content

fix: refactor ToIdentifier() to normalize flaggable enums - #2156

Merged
Vincent Biret (baywet) merged 15 commits into
mainfrom
fix/lowercase-json-schema-type-values
Feb 20, 2025
Merged

fix: refactor ToIdentifier() to normalize flaggable enums#2156
Vincent Biret (baywet) merged 15 commits into
mainfrom
fix/lowercase-json-schema-type-values

Conversation

@MaggieKimani1

@MaggieKimani1 Maggie Kimani (MaggieKimani1) commented Feb 18, 2025 •
edited by baywet
Loading

Copy link
Copy Markdown
Contributor
  • Adds support for normalizing flaggable enums by returning an array of strings
  • Supports casting of type arrays to the flaggable enum type
  • Adds tests to validate

Fixes #2078
Fixes #1924

baywet
Vincent Biret (baywet) requested changes Feb 18, 2025
View reviewed changes
Comment thread src/Microsoft.OpenApi/Models/OpenApiSchema.cs Resolved
Comment thread src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs Resolved
Comment thread src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs Resolved
Comment thread src/Microsoft.OpenApi/Validations/Rules/RuleHelpers.cs Resolved
baywet
Vincent Biret (baywet) requested changes Feb 19, 2025
View reviewed changes
Comment thread src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs Resolved
darrelmiller
Darrel (darrelmiller) reviewed Feb 19, 2025
View reviewed changes
Comment thread src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs Resolved
darrelmiller
Darrel (darrelmiller) reviewed Feb 19, 2025
View reviewed changes
Comment thread src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs Resolved
@baywet Vincent Biret (baywet) mentioned this pull request Feb 19, 2025
Closed
baywet
Vincent Biret (baywet) requested changes Feb 20, 2025
View reviewed changes

@baywet Vincent Biret (baywet) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!
A couple of additional remarks for performance.

Note: we could also use frozen dictionary for the static reference but I'm not sure the extra dependency is worth it.

Comment thread src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs Resolved
Comment thread src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs Resolved
Comment thread src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs Resolved
@MaggieKimani1 @baywet
Update src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs
fe50da3 
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
@MaggieKimani1 @baywet
Update src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs
cbb1407 
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
@MaggieKimani1 @baywet
Update src/Microsoft.OpenApi/Extensions/OpenApiTypeMapper.cs
fe19bfb 
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
@MaggieKimani1
chore: clean up
ee43027
@baywet
chore: removes redundant check
844b9b1 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
@baywet
Vincent Biret (baywet) enabled auto-merge (squash) February 20, 2025 16:49
@baywet
chore: cleans up api surface
3d7aa58 
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
This was referenced Jul 20, 2026
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Jul 29, 2026
Closed
This was referenced Aug 13, 2026
Closed
Closed
Open
Closed
Closed
Closed
Closed
This was referenced Aug 21, 2026
Closed
Closed
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Sep 2, 2026
Closed
This was referenced Sep 16, 2026
Closed
Open
Open
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Sep 26, 2026
Closed
This was referenced Oct 9, 2026
Closed
Merged
This was referenced Oct 19, 2026
Open
Open
This was referenced Oct 26, 2026
Open
Closed
Closed
Open
@dependabot dependabot Bot mentioned this pull request Nov 14, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darrelmiller Darrel (darrelmiller) darrelmiller left review comments
@baywet Vincent Biret (baywet) baywet approved these changes
@irvinesunday Irvine Sunday (irvinesunday) Awaiting requested review from irvinesunday
@gavinbarron Gavin Barron (gavinbarron) Awaiting requested review from gavinbarron
@millicentachieng Millicent Achieng (millicentachieng) Awaiting requested review from millicentachieng
@andrueastman Andrew Omondi (andrueastman) Awaiting requested review from andrueastman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The JsonSchemaType should offer a method to produce the JSON Schema type value v2 - type upgrade from string to flag enum - easy catch for consumers

3 participants

@MaggieKimani1 @darrelmiller @baywet