Visitar URL original
fix: circular ref guard by gavinbarron · Pull Request #3033 · microsoft/OpenAPI.NET · GitHub
Skip to content

fix: circular ref guard - #3033

Merged
Vincent Biret (baywet) merged 15 commits into
mainfrom
fix/circular-ref-guard
Aug 19, 2026
Merged

fix: circular ref guard#3033
Vincent Biret (baywet) merged 15 commits into
mainfrom
fix/circular-ref-guard

Conversation

@gavinbarron

@gavinbarron Gavin Barron (gavinbarron) commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Pull Request

Description

improved circular ref detection

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Related Issue(s)

Changes Made

improved parsing perf

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • All existing tests pass

Checklist

  • My code follows the code style of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Versions applicability

  • My change applies to the version 1.X of the library, if so PR link:
  • My change applies to the version 2.X of the library, if so PR link:
  • My change applies to the version 3.X of the library, if so PR link:
  • I have evaluated the applicability of my change against the other versions above.

See the contributing guidelines for more information about how patches are applied across multiple versions.

Additional Notes

@gavinbarron
Gavin Barron (gavinbarron) requested a review from a team as a code owner August 19, 2026 01:47
@github-code-quality

github-code-quality Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Code Coverage Overview

Languages: C#

C# / code-coverage/dotnet

The overall coverage in commit 419868b in the fix/circular-ref-gua... branch remains at 89%, unchanged from commit e0d5e9d in the main branch.

Show a code coverage summary of the most impacted files.
File main e0d5e9d fix/circular-ref-gua... 419868b +/-
/home/runner/wo...erenceHolder.cs 100% 95% -5%
/home/runner/wo...nApiDocument.cs 89% 89% 0%
/home/runner/wo...ackReference.cs 45% 45% 0%
/home/runner/wo...pleReference.cs 67% 67% 0%
/home/runner/wo...derReference.cs 80% 80% 0%
/home/runner/wo...inkReference.cs 69% 69% 0%
/home/runner/wo...ypeReference.cs 79% 79% 0%
/home/runner/wo...terReference.cs 82% 82% 0%
/home/runner/wo...temReference.cs 65% 65% 0%
/home/runner/wo...TagReference.cs 65% 74% +9%

Updated August 19, 2026 03:05 UTC

github-code-quality[bot]
github-code-quality Bot found potential problems Aug 19, 2026
View reviewed changes
Comment thread test/Microsoft.OpenApi.Tests/Models/References/OpenApiSchemaReferenceTests.cs Fixed
Comment thread src/Microsoft.OpenApi/Models/References/BaseOpenApiReferenceHolder.cs Fixed
Comment thread src/Microsoft.OpenApi/Models/References/BaseOpenApiReferenceHolder.cs Fixed
github-advanced-security[bot]
github-advanced-security Bot found potential problems Aug 19, 2026
View reviewed changes
Comment thread src/Microsoft.OpenApi/Models/References/BaseOpenApiReferenceHolder.cs Fixed
Comment thread src/Microsoft.OpenApi/Models/References/BaseOpenApiReferenceHolder.cs Fixed
@gavinbarron Gavin Barron (gavinbarron) changed the title Fix/circular ref guard fix: circular ref guard Aug 19, 2026
@sonarqubecloud

sonarqubecloud Bot commented Aug 19, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.4% Coverage on New Code
0.8% Duplication on New Code

See analysis details on SonarQube Cloud

@baywet
Vincent Biret (baywet) merged commit 8018d40 into main Aug 19, 2026
19 checks passed
@baywet
Vincent Biret (baywet) deleted the fix/circular-ref-guard branch August 19, 2026 12:36
Vincent Biret (baywet) added a commit that referenced this pull request Aug 19, 2026
@baywet @gavinbarron
fix: circular ref guard (#3033) (#3039)
406e6fd 
* fix: circular ref guard (#3033)

* fix: harden yaml parsing

* fix tests and nesting behavior on streams with SharpYaml update

* CodeQL fixes

* update benchmarks

* fix: circular ref guard

* update benchmarks

* fix: harden yaml parsing

* fix tests and nesting behavior on streams with SharpYaml update

* CodeQL fixes

* update benchmarks

* fix: circular ref guard

* update benchmarks

* codeql updates

Signed-off-by: Vincent Biret <vibiret@microsoft.com>

* chore: removes invalid property test due to bad cherry-pick

Signed-off-by: Vincent Biret <vibiret@microsoft.com>

* chore: refreshes performance reports

---------

Signed-off-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Gavin Barron <gavinbarron@microsoft.com>
This was referenced Aug 19, 2026
Closed
Closed
Closed
Closed
Closed
This was referenced Nov 10, 2026
Open
Open
Open
Open
Open
Open
Closed
Merged
Open
Open
Open
Open
Merged
Merged
Open
Open
Open
Open
Open
Closed
Open
Closed
Open
Open
Open
Open
Closed
Closed
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywet Vincent Biret (baywet) baywet approved these changes
+2 more reviewers
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
@github-code-quality github-code-quality[bot] github-code-quality[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gavinbarron @baywet @github-advanced-security