Repository navigation
Expand chart type supports #193
Description
Activity
Chenglong Wang (@Chenglong-MS) hi, i'd like to work on this issue. could you give more explanation on what exactly needs to be added
Rishabh Jain (@rishabhjain1712) That would be fantastic!
How about let's get started with adding Pie Chart (https://vega.github.io/vega-lite/examples/arc_pie.html) and US Map (https://vega.github.io/vega-lite/examples/geo_layer.html) as new chart templates to Data Formulator so people can create them?
A list of steps:
-
create a template of the chart similar to those already created (https://github.com/microsoft/data-formulator/blob/main/src/components/ChartTemplates.tsx#L68), specify which channels are available for the templates and how they should be assembled into the template.
-
if certain channels are not already supported, we need to add them to channel_list (https://github.com/microsoft/data-formulator/blob/main/src/components/ChartTemplates.tsx#L40)
-
Once these two are set up, we can test them with assemble_charts (https://github.com/microsoft/data-formulator/blob/main/src/app/utils.tsx#L194)
I expect Pie Chart will be easiest, how about starting with Pie Chart first?
-
Hey Chenglong Wang (@Chenglong-MS) apologies for the delay, I was battling a series of interviews (and losing 😅). Starting this today.
Reacted by Chenglong WangChenglong Wang (@Chenglong-MS) what about the icons for both of them?
We probably don't need to worry about icons for now, can use some MUI icons as placeholders.
Chenglong Wang (@Chenglong-MS) Hi! Since this issue has been quiet for a while, I went ahead and explored an implementation for it. I now have a working prototype.
If this looks aligned with the expected direction, I can open a PR and refine based on feedback. Let me know what you think!Here are the results:
Data formulator support new charts based on chart templates:
https://github.com/microsoft/data-formulator/blob/main/src/components/ChartTemplates.tsx
What are new charts you are interested in? Let's expand charts supported by the tool.