Repository navigation
Automatically parse feedback value #184
Description
When feedback is submitted, the actionValue.feedback comes in as a JSON.
Should we parse this thing to help out devs? Or leave it up to them? I see a case for both.
If we parse it for them, improved devex
If we don't, they can store the whole thing, and if more fields get added, they won't need to change anything.
Though, I think most people are parsing it and storing the text directly...
Thoughts?
Activity
corinagum commentedon Jun 5, 2025
Personally I lean towards providing the JSON. Parsing it "modifying" the response received and therefore makes us more opinionated, which we want to avoid where possible.
lilyydu commentedon Jun 5, 2025
also lean towards providing JSON
yash01699 commentedon Sep 27, 2025
Hi, can I take up this issue if this is still open and if you guys are still planning on going ahead with this change?
heyitsaamir commentedon May 14, 2026
Closing this out based on the discussion above. The current direction is to keep the raw feedback JSON rather than parse it for developers, since parsing would make the SDK more opinionated and create future maintenance/schema risk.
heyitsaamir commentedon May 14, 2026
Reopening — closed by mistake during a local triage pass. Sorry for the noise.
yash01699 commentedon May 15, 2026
Aamir Jawaid (@heyitsaamir) could you assign this to me if this is still available?
heyitsaamir commentedon May 15, 2026
Yashasvi Nancherla (@yash01699) thank you -- we are just triaging some of these. Let me check with the team if this is something we should do or not. I feel like we should, but want to get consensus.
Value comes as a string right now, and we parse it as a feedback object. If we were to do this, we would need to do a step after the router where we allow objects to be processed before they are sent to the handler.