Consider to add .js extenstion to main entry point (bin/mocha) for better ES modules compatibility #4267

Activity

1. evg656e

   added

   type: featureenhancement proposalenhancement proposal

   on May 3, 2020
2. cspotcode commented on May 4, 2020

   

   cspotcode

   on May 4, 2020

   Contributor

   More actions

   FYI I posted on nodejs/node#33223 that I actually believe this is a bug on node's side. mocha declares itself to be a commonjs module, not ESM, so node should not be attempting to load it as ESM.

   👍React with 👍2Reacted by Juerg B. and Gil Tayar
3. boneskull commented on Jun 10, 2020

   

   boneskull

   on Jun 10, 2020

   Member

   More actions

   bin/mocha is not the main entry point; it's an executable. You should not be requiring or importing it.

   See #4298 for further discussion.
4. boneskull

   closed this as completedon Jun 10, 2020
5. cspotcode commented on Jun 10, 2020

   

   cspotcode

   on Jun 10, 2020

   Contributor

   More actions

   @boneskull To clarify, the use-case is invoking the executable while passing --loader to node, not to require or import the main entry point. Makes more sense when the example uses _mocha instead of mocha; not sure if _mocha has been deprecated.

   # Fails due to the bug I filed in node's issue tracker
   node --loader ts-node/esm node_modules/mocha/bin/_mocha --extension ts
   
   # Allowing mocha to pass the --loader flag to node (this works)
   mocha --loader=ts-node/esm --extension ts
   
   # Omitting the equal sign breaks, even though node supports this.  Worth noting.
   mocha --loader ts-node/esm --extension ts
   

   ❤️React with ❤️3Reacted by EviSONG, Adrienne Walker and Maik Riechert
6. boneskull commented on Jun 10, 2020

   

   boneskull

   on Jun 10, 2020

   Member

   More actions

   Ahh, yes, thanks.

   The recommended way would be to use mocha instead of node; it will spawn a node process, running lib/cli/cli.js with the non-Mocha flags passed to node.

   _mocha is just a stub for lib/cli/cli.js, but it’s still there for backwards-compat.

   we should open an issue to look into the = thing.