Repository navigation
add revive for go #2429
Description
Hi,
Can we have an addition to the go linters for revive? https://github.com/mgechev/revive
I copied the golangci-lint definition and added this locally and it seems to work
function! neomake#makers#ft#go#revive() abort
return {
\ 'exe': 'revive',
\ 'args': ['%t'],
\ 'cwd': '%:h',
\ 'errorformat':
\ '%f:%l:%c: %m,' .
\ '%f:%l: %m'
\ }
endfunction
Thanks
Activity
blueyed commentedon Sep 26, 2019
Sure, please create a PR.
From the description it looks like it could be preferred automatically (based on
executable('revive')then also over golint?neomake/autoload/neomake/makers/ft/go.vim
Line 10 in ba38b87
blueyed commentedon Sep 26, 2019
Also example output, and a test would be nice to have then here or with the PR.
delfick commentedon Sep 26, 2019
ah yeah, I can have a look at doing that.
After some more consideration, how would I make it have a -config and -exclude options that you can set?
blueyed commentedon Sep 26, 2019
Does it support config files that it picks up automatically?
That's usually the best.
delfick commentedon Sep 26, 2019
it would appear that revive only looks in your home directory for a config, so I could do something similar to what pylama does
I'm not sure about exclude, but I did just realise it doesn't make sense to have it specified anyway because we're running revive against specific files.
blueyed commentedon Sep 26, 2019
Hmm.. not sure what problem you are trying to solve.
See #1859 for appending args to existing makers. I think I should finish #2161.
delfick commentedon Sep 26, 2019
Does that allow for adding arguments before the last argument?
Because the -config argument has to come before the path you're linting.
blueyed commentedon Sep 26, 2019
The path gets appended automatically in the end (via
append_file=1setting).Check also #2161.
delfick commentedon Sep 26, 2019
ah, awesome :)
[go] Add a maker for revive