Visitar URL original
build: pin envinfo versions in github actions · nodejs/node@f4e7bf1 · GitHub
Skip to content

Commit f4e7bf1

Browse files
joyeecheungrichardlau
joyeecheung
authored and
richardlau
committed
build: pin envinfo versions in github actions
Currently they all run `npx envinfo` without pinning the version. This can be a supply-chain risk. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #64117 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
1 parent 189e830 commit f4e7bf1

12 files changed

Lines changed: 18 additions & 18 deletions

‎.github/workflows/build-tarball.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ jobs:
8383
python-version: ${{ env.PYTHON_VERSION }}
8484
allow-prereleases: true
8585
- name: Environment Information
86-
run: npx envinfo
86+
run: npx envinfo@7.21.0
8787
- name: Make tarball
8888
run: |
8989
export DISTTYPE=nightly
@@ -125,7 +125,7 @@ jobs:
125125
with:
126126
version: v0.16.0
127127
- name: Environment Information
128-
run: npx envinfo
128+
run: npx envinfo@7.21.0
129129
- name: Download tarball
130130
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
131131
with:

‎.github/workflows/coverage-linux-without-intl.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ jobs:
6868
with:
6969
version: v0.16.0
7070
- name: Environment Information
71-
run: npx envinfo
71+
run: npx envinfo@7.21.0
7272
- name: Install gcovr
7373
run: pip install gcovr==7.2
7474
- name: Configure

‎.github/workflows/coverage-linux.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ jobs:
6868
with:
6969
version: v0.16.0
7070
- name: Environment Information
71-
run: npx envinfo
71+
run: npx envinfo@7.21.0
7272
- name: Install gcovr
7373
run: pip install gcovr==7.2
7474
- name: Configure

‎.github/workflows/coverage-windows.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ jobs:
8484
rustup override set "$RUSTC_VERSION"
8585
rustup --version
8686
- name: Environment Information
87-
run: npx envinfo
87+
run: npx envinfo@7.21.0
8888
- name: Build
8989
run: ./vcbuild.bat clang-cl v8temporal
9090
# TODO(bcoe): investigate tests that fail with coverage enabled

‎.github/workflows/daily-wpt-fyi.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ jobs:
4444
python-version: ${{ env.PYTHON_VERSION }}
4545
allow-prereleases: true
4646
- name: Environment Information
47-
run: npx envinfo
47+
run: npx envinfo@7.21.0
4848

4949
# install a version and checkout
5050
- name: Get latest nightly

‎.github/workflows/daily.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
with:
2525
node-version: ${{ env.NODE_VERSION }}
2626
- name: Environment Information
27-
run: npx envinfo
27+
run: npx envinfo@7.21.0
2828
- name: Build lto
2929
run: |
3030
sudo apt-get update && sudo apt-get install ninja-build -y

‎.github/workflows/doc.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
with:
3333
node-version: ${{ env.NODE_VERSION }}
3434
- name: Environment Information
35-
run: npx envinfo
35+
run: npx envinfo@7.21.0
3636
- name: Build
3737
run: NODE=$(command -v node) make doc-only
3838
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1

‎.github/workflows/linters.yml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
with:
3434
node-version: ${{ env.NODE_VERSION }}
3535
- name: Environment Information
36-
run: npx envinfo
36+
run: npx envinfo@7.21.0
3737
- name: Lint addon docs
3838
run: NODE=$(command -v node) make lint-addon-docs
3939
lint-cpp:
@@ -49,7 +49,7 @@ jobs:
4949
python-version: ${{ env.PYTHON_VERSION }}
5050
allow-prereleases: true
5151
- name: Environment Information
52-
run: npx envinfo
52+
run: npx envinfo@7.21.0
5353
- name: Lint C/C++ files
5454
run: make lint-cpp
5555
format-cpp:
@@ -70,7 +70,7 @@ jobs:
7070
python-version: ${{ env.PYTHON_VERSION }}
7171
allow-prereleases: true
7272
- name: Environment Information
73-
run: npx envinfo
73+
run: npx envinfo@7.21.0
7474
- name: Format C/C++ files
7575
run: |
7676
make format-cpp-build
@@ -103,7 +103,7 @@ jobs:
103103
with:
104104
node-version: ${{ env.NODE_VERSION }}
105105
- name: Environment Information
106-
run: npx envinfo
106+
run: npx envinfo@7.21.0
107107
- name: Lint JavaScript files
108108
run: |
109109
set +e
@@ -184,7 +184,7 @@ jobs:
184184
python-version: ${{ env.PYTHON_VERSION }}
185185
allow-prereleases: true
186186
- name: Environment Information
187-
run: npx envinfo
187+
run: npx envinfo@7.21.0
188188
- name: Lint Python
189189
run: |
190190
make lint-py-build
@@ -208,7 +208,7 @@ jobs:
208208
python-version: ${{ env.PYTHON_VERSION }}
209209
allow-prereleases: true
210210
- name: Environment Information
211-
run: npx envinfo
211+
run: npx envinfo@7.21.0
212212
- name: Lint YAML
213213
run: |
214214
make lint-yaml-build || true

‎.github/workflows/test-internet.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ jobs:
6565
with:
6666
version: v0.16.0
6767
- name: Environment Information
68-
run: npx envinfo
68+
run: npx envinfo@7.21.0
6969
- name: Build
7070
run: make build-ci -j4 V=1 CONFIG_FLAGS="--error-on-warn"
7171
- name: Test Internet

‎.github/workflows/test-linux-quic.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ jobs:
7070
with:
7171
version: v0.16.0
7272
- name: Environment Information
73-
run: npx envinfo
73+
run: npx envinfo@7.21.0
7474
- name: Build
7575
working-directory: node
7676
run: make build-ci -j4 V=1 CONFIG_FLAGS="--error-on-warn --v8-enable-temporal-support --experimental-quic"

0 commit comments

Comments
 (0)