Visitar URL original
undici_version.h and acorn_version.h displaying wrong update script path · Issue #50159 · nodejs/node · GitHub
Skip to content

undici_version.h and acorn_version.h displaying wrong update script path #50159

Closed
#50175
#50165
Closed
undici_version.h and acorn_version.h displaying wrong update script path#50159
#50175
#50165
Labels
good first issueIssues that are suitable for first-time contributors.

Description

@MrJithil
MrJithil
opened on Oct 12, 2023

Comments in below files are pointing to wrong path of their corresponding dep update scripts.

Below changes needed.

  • undici_version.h - // Refer to tools/update-undici.sh must be // Refer to tools/dep_updaters/update-undici.sh
  • update-acorn.sh - // Refer to tools/update-acorn.sh must be // Refer to tools/dep_updaters/update-acorn.sh

Changes needed in deps_update/update_.sh scripts

Activity

  1. MrJithil commented on Oct 12, 2023

    @MrJithil
    MrJithil
    on Oct 12, 2023
    MemberAuthor

    Please help me to add the label good first issue

  2. panva
    added
    good first issueIssues that are suitable for first-time contributors.
    on Oct 12, 2023

  3. capable-average commented on Oct 12, 2023

    @capable-average
    capable-average
    on Oct 12, 2023

    can you assign this to me?

  4. aduh95
    closed this as completedin #50165on Oct 12, 2023
  5. aduh95
    added 2 commits that reference this issue on Oct 12, 2023

    tools: fix comments referencing dep_updaters scripts

    766198b

    tools: update comment in `update-uncidi.sh` and `acorn_version.h`

    f09a50c
  6. targos
    added a commit that references this issue on Oct 23, 2023

    tools: update comment in `update-uncidi.sh` and `acorn_version.h`

    5df3d5a
  7. targos
    added 2 commits that reference this issue on Nov 11, 2023

    tools: fix comments referencing dep_updaters scripts

    b959d36

    tools: update comment in `update-uncidi.sh` and `acorn_version.h`

    05ee350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueIssues that are suitable for first-time contributors.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions