test/client-request.js, 'request dump' test case always takes ~ 5 seconds #3120

Activity

1. Uzlopak

   added

   bugSomething isn't workingSomething isn't working

   on Apr 15, 2024
2. Uzlopak commented on Apr 15, 2024

   

   Uzlopak

   on Apr 15, 2024

   ContributorAuthor

   More actions

   The same with 'request DELETE, content-length=0, with body' in test/content-length.js
3. Uzlopak commented on Apr 17, 2024

   

   Uzlopak

   on Apr 17, 2024

   ContributorAuthor

   More actions

   I investigated it further. The tests will run faster if I manually set shouldKeepAlive to false.

   I guess this is also related to issue-803, as it never sending the whole payload to the client.

   Also i have the fealing that contentLenght is not stored properly as an attribute . It is set as empty string. The numbers are added.
4. mweberxyz commented on Apr 18, 2024

   

   mweberxyz

   on Apr 18, 2024

   Last edited by mweberxyz

   Contributor

   More actions

   Dunno if relevant, but if you call dump({ limit: 4 }) (or any number less than the Content-Length) in the test it'll also finish right away.
5. Uzlopak commented on Apr 18, 2024

   

   Uzlopak

   on Apr 18, 2024

   ContributorAuthor

   More actions

   If you set the dump limit to 4, then it will result in an error, which gets passed to noop. Thats why it is finishing early.
6. mweberxyz commented on Apr 18, 2024

   

   mweberxyz

   on Apr 18, 2024

   Last edited by mweberxyz

   Contributor

   More actions

   Seems working as expected then if I am understanding everything correctly. If dump is able to consume the entire response, then the socket is clear for another request, and the client's disconnect event won't fire until the keep alive timeout.

   For 'request dump', would it be preferable to replace

       client.on('disconnect', () => {
         t.strictEqual(dumped, true)
       })
   

   with

       client.on('drain', () => {
         setImmediate(() => t.strictEqual(dumped, true))
       })
   

   ?
7. Uzlopak

   closed this as completedin #3135on Apr 19, 2024