Visitar URL original
exporters/otlp: default max request size to 64 MiB (#8365) · open-telemetry/opentelemetry-go@f593185 · GitHub
Skip to content

Commit f593185

Browse files
authored
exporters/otlp: default max request size to 64 MiB (#8365)
Per open-telemetry/opentelemetry-proto#782 where we agreed to have 64 MiB as the default limit.
1 parent f02feac commit f593185

17 files changed

Lines changed: 28 additions & 28 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -67,18 +67,18 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
6767

6868
- Fix `FixedSizeReservoir` in `go.opentelemetry.io/otel/sdk/metric/exemplar` to safely handle zero size.
6969
A capacity check in the constructor initializes the reservoir safely and skips initialization for zero-cap; early returns in `Offer()` and `Collect()` ensure no-op behavior. (#8295)
70-
- Limit OTLP request size to 32 MiB by default in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc`.
71-
The limit applies before compression, oversized requests are treated as non-retryable errors, and the limit can be configured with the new `WithMaxRequestSize` option. (#8157)
72-
- Limit OTLP request size to 32 MiB by default in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`.
73-
The limit applies before compression, oversized requests are treated as non-retryable errors, and the limit can be configured with the new `WithMaxRequestSize` option. (#8157)
74-
- Limit OTLP request size to 32 MiB by default in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc`.
75-
The limit applies before compression, oversized requests are treated as non-retryable errors, and the limit can be configured with the new `WithMaxRequestSize` option. (#8157)
76-
- Limit OTLP request size to 32 MiB by default in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`.
77-
The limit applies before compression, oversized requests are treated as non-retryable errors, and the limit can be configured with the new `WithMaxRequestSize` option. (#8157)
78-
- Limit OTLP request size to 32 MiB by default in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc`.
79-
The limit applies before compression, oversized requests are treated as non-retryable errors, and the limit can be configured with the new `WithMaxRequestSize` option. (#8157)
80-
- Limit OTLP request size to 32 MiB by default in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`.
81-
The limit applies before compression, oversized requests are treated as non-retryable errors, and the limit can be configured with the new `WithMaxRequestSize` option. (#8157)
70+
- Limit OTLP request size to 64 MiB by default in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc`.
71+
The limit applies before compression, oversized requests are treated as non-retryable errors, and the limit can be configured with the new `WithMaxRequestSize` option. (#8157, #8365)
72+
- Limit OTLP request size to 64 MiB by default in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`.
73+
The limit applies before compression, oversized requests are treated as non-retryable errors, and the limit can be configured with the new `WithMaxRequestSize` option. (#8157, #8365)
74+
- Limit OTLP request size to 64 MiB by default in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc`.
75+
The limit applies before compression, oversized requests are treated as non-retryable errors, and the limit can be configured with the new `WithMaxRequestSize` option. (#8157, #8365)
76+
- Limit OTLP request size to 64 MiB by default in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`.
77+
The limit applies before compression, oversized requests are treated as non-retryable errors, and the limit can be configured with the new `WithMaxRequestSize` option. (#8157, #8365)
78+
- Limit OTLP request size to 64 MiB by default in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc`.
79+
The limit applies before compression, oversized requests are treated as non-retryable errors, and the limit can be configured with the new `WithMaxRequestSize` option. (#8157, #8365)
80+
- Limit OTLP request size to 64 MiB by default in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`.
81+
The limit applies before compression, oversized requests are treated as non-retryable errors, and the limit can be configured with the new `WithMaxRequestSize` option. (#8157, #8365)
8282
- Fix gzipped request body replay on redirect in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`. (#8135)
8383
- Fix gzipped request body replay on redirect in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#8152)
8484
- `go.opentelemetry.io/otel/exporters/prometheus` now uses `Value.String` formatting for label values following the [OpenTelemetry AnyValue representation for non-OTLP protocols](https://opentelemetry.io/docs/specs/otel/common/#anyvalue). (#8170)

‎exporters/otlp/otlplog/otlploggrpc/config.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import (
2727
var (
2828
defaultEndpoint = "localhost:4317"
2929
defaultTimeout = 10 * time.Second
30-
defaultMaxRequestSize = 32 * 1024 * 1024
30+
defaultMaxRequestSize = 64 * 1024 * 1024
3131
defaultRetryCfg = retry.DefaultConfig
3232
)
3333

‎exporters/otlp/otlplog/otlploggrpc/config_test.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -497,7 +497,7 @@ func TestNewConfig(t *testing.T) {
497497
}(otel.GetErrorHandler()))
498498
c := newConfig(tc.options)
499499
if !tc.want.maxRequestSize.Set {
500-
tc.want.maxRequestSize = newSetting(defaultMaxRequestSize)
500+
tc.want.maxRequestSize = newSetting(64 * 1024 * 1024)
501501
}
502502

503503
// Do not compare pointer values.

‎exporters/otlp/otlplog/otlploghttp/config.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ var (
2626
defaultEndpoint = "localhost:4318"
2727
defaultPath = "/v1/logs"
2828
defaultTimeout = 10 * time.Second
29-
defaultMaxRequestSize = 32 * 1024 * 1024
29+
defaultMaxRequestSize = 64 * 1024 * 1024
3030
defaultProxy HTTPTransportProxyFunc = http.ProxyFromEnvironment
3131
defaultRetryCfg = retry.DefaultConfig
3232
)

‎exporters/otlp/otlplog/otlploghttp/config_test.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -512,7 +512,7 @@ func TestNewConfig(t *testing.T) {
512512
}(otel.GetErrorHandler()))
513513
c := newConfig(tc.options)
514514
if !tc.want.maxRequestSize.Set {
515-
tc.want.maxRequestSize = newSetting(defaultMaxRequestSize)
515+
tc.want.maxRequestSize = newSetting(64 * 1024 * 1024)
516516
}
517517

518518
// Do not compare pointer values.

‎exporters/otlp/otlpmetric/otlpmetricgrpc/internal/oconf/options.go‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎exporters/otlp/otlpmetric/otlpmetricgrpc/internal/oconf/options_test.go‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎exporters/otlp/otlpmetric/otlpmetrichttp/internal/oconf/options.go‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎exporters/otlp/otlpmetric/otlpmetrichttp/internal/oconf/options_test.go‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎exporters/otlp/otlptrace/otlptracegrpc/internal/otlpconfig/options.go‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)