Commit f7b313a

See proposal.md — Why for motivation. The `owncloudApp/build.gradle` release build type currently has no `minifyEnabled` setting (defaults to `false`). No `proguard-rules.pro` exists in `owncloudApp/`. A legacy `proguard.cfg` exists at the repo root but is not referenced by any build script. AGP 9.x uses R8 by default; no explicit R8 toolchain switch is needed.

**Goals:**

- Enable R8 code shrinking for `owncloudApp` release builds only.

- Author keep rules sufficient to prevent runtime breakage from missing classes.

**Non-Goals:**

- Enabling minification in library modules or debug builds.

- Adding obfuscation suppression (`-dontobfuscate`) — obfuscation stays on.

- Integrating a crash-reporting SDK or automating mapping file upload.

**Decision:** Reference `proguard-android-optimize.txt` (not `proguard-android.txt`) as the AGP-provided base rules file.

**Rationale:** `proguard-android-optimize.txt` enables code-level optimizations (constant propagation, dead code removal across methods) that `proguard-android.txt` does not. This maximises APK size reduction and aligns with Google's current recommendation for new projects.

**Alternative considered:** `proguard-android.txt` — less aggressive, larger output, not needed given we are starting from scratch with R8.

**Decision:** All custom keep rules live in one file at `owncloudApp/proguard-rules.pro`, referenced alongside the AGP default.

**Rationale:** Library consumer rules (Room, Kotlin Coroutines, OkHttp, Moshi, Koin) are already bundled with each library's AAR and applied automatically by R8. Only app-level classes that R8 cannot infer are instantiated by name (WorkManager workers, classes loaded via reflection) need explicit keep rules. A single file is easy to audit and extend.

**Alternative considered:** Splitting rules per concern into multiple `.pro` files — unnecessary complexity for the volume of custom rules needed here.

| Category | Rule strategy | Rationale |

|---|---|---|

| `CoroutineWorker` subclasses in `com.owncloud.android.workers` | `-keep class com.owncloud.android.workers.** { public <init>(...); }` | WorkManager instantiates workers by class name from the `WorkRequest`; renaming breaks lookup |

| Moshi `@JsonClass`-annotated models in `owncloudComLibrary` | `-keep @com.squareup.moshi.JsonClass class * { *; }` | KSP generates adapters at compile time, but the annotated model fields must not be renamed or JSON field mapping breaks |

| Room entities and DAOs | Already covered by Room's bundled consumer rules — verify after first build by inspecting `configuration.txt` | Room ships its own `-keep` rules in its AAR |

| Koin wiring | No keep rules needed | Koin resolves dependencies via reified type parameters, not reflection on class names |

| All other classes | Default R8 behavior (shrink + obfuscate) | No known issues; the `configuration.txt` dump after the first build is the safety net |

**Decision:** Inspect `owncloudApp/build/outputs/mapping/originalRelease/configuration.txt` after the first successful `assembleOriginalRelease` to confirm all consumer rules were applied and spot any unexpected gaps before opening the PR.

**Rationale:** R8 merges rules cumulatively (AGP default + `proguard-rules.pro` + library consumer rules). The merged dump is the ground truth; reviewing it catches over-keeping and under-keeping early.

- **[Risk] Keep rules are incomplete** → Mitigation: Run the release APK on a device/emulator and exercise login, file listing, upload, download, and background sync before opening the PR. Missing keep rules typically surface as `ClassNotFoundException` or Moshi deserialization errors at runtime, not at build time.

- **[Risk] R8 removes code that is used only via reflection (e.g. custom View classes inflated from XML)** → Mitigation: Review the R8 usage report (`usage.txt` in the mapping output directory) and add `@Keep` annotations or explicit rules for any incorrectly removed class.

- **[Risk] Detekt flags new annotations or changed constructs** → Mitigation: Run `./gradlew detekt` locally after every change to the keep rules file and before pushing.

1. Add `minifyEnabled true` and `proguardFiles` to the `release` build type in `owncloudApp/build.gradle`.

2. Create `owncloudApp/proguard-rules.pro` with keep rules per D3.

3. Run `./gradlew assembleOriginalRelease` and resolve any build errors.

4. Inspect `configuration.txt` (D4) and iterate on `proguard-rules.pro` as needed.

5. Install the release APK on a device/emulator and smoke-test (login, file listing, upload, download, background sync).

6. Run `./gradlew testDebugUnitTest testMdmDebugUnitTest` to confirm unit tests pass.

7. Run `./gradlew detekt` to confirm zero issues.

**Rollback:** Revert `owncloudApp/build.gradle` to remove the `minifyEnabled` and `proguardFiles` lines. Delete `owncloudApp/proguard-rules.pro`. No database migrations or server-side changes are involved.

The release APK published on Google Play has DEX code optimization disabled because `minifyEnabled` is not set in `owncloudApp/build.gradle`. Google Play Console flags this in Android Vitals and requires it to be fixed by February 2027. Enabling R8 also reduces APK size.

- Enable `minifyEnabled true` in the `release` build type of `owncloudApp/build.gradle`.

- Add `proguardFiles` referencing `getDefaultProguardFile('proguard-android-optimize.txt')` and a new `owncloudApp/proguard-rules.pro`.

- Create `owncloudApp/proguard-rules.pro` with keep rules for: `CoroutineWorker` subclasses in `com.owncloud.android.workers`, Moshi `@JsonClass`-annotated response models in `owncloudComLibrary`, and any classes loaded by reflection or the Android framework.

- Debug builds remain unaffected (`minifyEnabled false`).

- Library modules (`owncloudData`, `owncloudDomain`, `owncloudComLibrary`) are not changed.

- `r8-optimisation`: Release build configuration requirements — minification enabled, keep rules covering Workers, Moshi models, and reflection-loaded classes.

None — no existing spec-level behavior changes. The app's observable user-facing functionality is unchanged.

- **`owncloudApp/build.gradle`**: `release` build type gains `minifyEnabled true` and `proguardFiles`.

- **`owncloudApp/proguard-rules.pro`** (new file): keep rules for Workers, Moshi models, and reflection-loaded classes.

- No new runtime dependencies introduced.

Defines the build requirements for R8 code shrinking and optimization in release builds of the ownCloud Android app, ensuring APKs pass Google Play's DEX optimization check.

The `owncloudApp` release build type SHALL have `minifyEnabled true` set, causing the AGP/R8 toolchain to shrink and optimize the DEX code.

- **WHEN** `./gradlew assembleOriginalRelease` is executed

- **THEN** the build completes without errors and produces a valid, installable APK at `owncloudApp/build/outputs/apk/original/release/`

- **WHEN** `./gradlew assembleOriginalDebug` is executed

- **THEN** `minifyEnabled` is false for the debug build type and no shrinking is applied

The ProGuard/R8 rules file SHALL include keep rules that prevent shrinking or renaming of: all `CoroutineWorker` subclasses in `com.owncloud.android.workers`, Moshi `@JsonClass`-annotated response model classes in `owncloudComLibrary`, and any other classes instantiated by name via reflection or the Android framework.

- **WHEN** a background sync or upload WorkRequest is enqueued and executed in a release build

- **THEN** WorkManager successfully instantiates the worker class by its registered name with no `ClassNotFoundException`

- **WHEN** the app deserializes a JSON response from the ownCloud server in a release build

- **THEN** all annotated fields are correctly mapped and no deserialization errors occur due to renamed fields

The `owncloudComLibrary`, `owncloudData`, and `owncloudDomain` library modules SHALL keep `minifyEnabled false`; only `owncloudApp` is changed.

- **WHEN** any library module is built independently

- **THEN** its build configuration is identical to before this change (no minification applied)

- [ ] 1.1 Add `minifyEnabled true` to the `release` build type in `owncloudApp/build.gradle`

- [ ] 1.2 Add `proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'` to the `release` build type in `owncloudApp/build.gradle`

- [ ] 1.3 Verify that the `debug` build type in `owncloudApp/build.gradle` has no `minifyEnabled` change (remains false by default)

- [ ] 2.1 Create `owncloudApp/proguard-rules.pro` with keep rules for all `CoroutineWorker` subclasses in `com.owncloud.android.workers` (9 workers: `OldLogsCollectorWorker`, `AutomaticUploadsWorker`, `AvailableOfflinePeriodicWorker`, `DownloadFileWorker`, `RemoveLocallyFilesWithLastUsageOlderThanGivenTimeWorker`, `AccountDiscoveryWorker`, `UploadFileFromFileSystemWorker`, `RemoveSourceFileWorker`, `UploadFileFromContentUriWorker`)

- [ ] 2.2 Add keep rules to `owncloudApp/proguard-rules.pro` for all Moshi `@JsonClass`-annotated response model classes in `owncloudComLibrary` (covering: `CommonOcsResponse`, `ShareeResponse`, `ShareItem`, `TokenResponse`, `ClientRegistrationResponse`, `OIDCDiscoveryResponse`, `WebFingerResponse`, `AppRegistryResponse`, `SpacesResponse`, `RoleResponse`, `CapabilityResponse`, `UserInfoResponse`, `MembersResponse`, and related)

- [ ] 2.3 Add a class-level keep rule for any other classes instantiated by name via the Android framework (e.g. custom `View` subclasses inflated from XML, if any are identified)

- [ ] 3.1 Run `./gradlew assembleOriginalRelease` and resolve any build errors

- [ ] 3.2 Inspect `owncloudApp/build/outputs/mapping/originalRelease/configuration.txt` to verify that Room consumer rules and Coroutines rules were applied automatically, and that all custom keep rules appear in the merged output

- [ ] 3.3 Inspect `owncloudApp/build/outputs/mapping/originalRelease/usage.txt` to check for any incorrectly removed classes and add additional keep rules if needed

- [ ] 3.4 Confirm mapping file is present at `owncloudApp/build/outputs/mapping/originalRelease/mapping.txt`

- [ ] 4.1 Run `./gradlew testDebugUnitTest testMdmDebugUnitTest --continue` and confirm all unit tests pass

- [ ] 4.2 Run `./gradlew detekt` and confirm zero issues

- [ ] 4.3 Install the release APK on a device or emulator and perform the smoke test: login, file listing, upload, download

- [ ] 4.4 Trigger a background sync (automatic upload) and confirm it completes without a `ClassNotFoundException` from WorkManager

- [ ] 5.1 Create `changelog/unreleased/XXXX` (replace `XXXX` with the PR number once known) with the following content:

| Test name | Steps to execute | Expected result | Result | Comments |

|---|---|---|---|---|

| Release build compiles | Run `./gradlew assembleOriginalRelease` | Build succeeds, APK produced | | |

| Mapping file generated | Check `owncloudApp/build/outputs/mapping/originalRelease/mapping.txt` after release build | File exists and is non-empty | | |

| Debug build unaffected | Run `./gradlew assembleOriginalDebug` | Build succeeds, no minification applied | | |

| Unit tests pass | Run `./gradlew testDebugUnitTest testMdmDebugUnitTest` | All tests green | | |

| Detekt zero issues | Run `./gradlew detekt` | Zero issues reported | | |

| Login works in release APK | Install release APK, open app, log in to an ownCloud server | Login completes, files listed | | |

| File listing works | Navigate through folders in release APK | Folders and files display correctly | | |

| File upload works | Upload a file from the release APK | File appears on server | | |

| File download works | Download a file in the release APK | File saved locally and opens correctly | | |

| Background sync works | Trigger automatic upload via release APK | Upload worker completes with no `ClassNotFoundException` | | |

| Moshi deserialization works | Perform any server request returning JSON (e.g. capabilities, spaces) in release APK | Response parsed correctly, no deserialization errors | | |