Activity

1. jesmrec

   added

   QA

   on Jun 7, 2023
2. jesmrec

   assigned

   jesmrec

   ,

   manuelplazaspalacio

   and

   JuancaG05

   on Jun 7, 2023
3. JuancaG05

   changed the title [-]Test review[/-] [+][EPIC] Test refactort[/+] on Jun 13, 2023
4. JuancaG05

   changed the title [-][EPIC] Test refactort[/-] [+][EPIC] Tests refactoring[/+] on Jun 13, 2023
5. JuancaG05

   added

   Epic

   on Jun 13, 2023
6. JuancaG05

   assigned

   Aitorbp

   on Oct 3, 2023
7. JuancaG05 commented on Nov 23, 2023

   

   JuancaG05

   on Nov 23, 2023

   Last edited by JuancaG05

   Contributor

   More actions

   Datasources classes

   When they are not like that, we should move the datasources implementations to a package called datasources.implementation, and make the test classes in the same corresponding package.

   OCLocalAppRegistryDataSource:
   (No tests for this class currently)

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCRemoteAppRegistryDataSource:
   (No tests for this class currently)

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCLocalAuthenticationDataSource:
   (No tests for this class currently)

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCRemoteAuthenticationDataSource:
   This class cannot be tested because we cannot access from the test the objects used inside the methods (they are created internally)
   (No tests for this class currently)

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCLocalCapabilitiesDataSource:
   Only insert method test has a verify and delete method has no tests

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCRemoteCapabilitiesDataSource:
   No verify in the test method

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCLocalFileDataSource:
   The tests that are currently done check the result and verify the calls, but we don't have tests for getFileByIdAsFlow, getFileByRemoteId, getSearchFolderContent, getSearchAvailableOfflineFolderContent, getSearchSharedByLinkFolderContent, getFolderContentWithSyncInfoAsFlow, getSharedByLinkWithSyncInfoForAccountAsFlow, getFilesWithSyncInfoAvailableOfflineFromAccountAsFlow, getFilesAvailableOfflineFromAccount, getFilesAvailableOfflineFromEveryAccount, moveFile, saveFilesInFolderAndReturnThem, saveFile, saveConflict, cleanConflict, deleteFilesForAccount, renameFile, disableThumbnailsForFile, updateAvailableOfflineStatusForFile, updateDownloadedFilesStorageDirectoryInStoragePath, saveDownloadWorkerUuid, and cleanWorkersUuid

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCRemoteFileDataSource:
   The tests that are currently done check the result and verify the calls, but we don't have tests for copyFile, moveFile, readFile, refreshFolder, deleteFile, and renameFile

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCFolderBackupLocalDataSource:
   (No tests for this class currently)

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCRemoteOAuthDataSource:
   We check the result but we don't verify the calls to other methods

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCSharedPreferencesProvider:
   (No tests for this class currently)

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCRemoteServerInfoDataSource:

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCRemoteShareeDataSource:
   We check the result but we don't verify the calls to other methods

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCLocalShareDataSource:
   Current tests don't have verify, and we don't have tests for insert (receiving a list of shares) and deleteShares

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCRemoteShareDataSource:
   We check the result but we don't verify the calls to other methods

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCLocalSpacesDataSource:
   (No tests for this class currently)

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCRemoteSpacesDataSource:
   (No tests for this class currently)

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   ScopedStorageProvider:
   (No tests for this class currently)

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCLocalTransferDataSource:
   (No tests for this class currently)

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCLocalUserDataSource:
   Current tests don't have verify, and we don't have tests for getAllUserQuotas and deleteQuotaForAccount

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCRemoteUserDataSource:
   We check the result but we don't verify the calls to other methods

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCRemoteWebFingerDatasource:
   (No tests for this class currently)

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes
8. JuancaG05 commented on Nov 24, 2023

   

   JuancaG05

   on Nov 24, 2023

   Last edited by joragua

   Contributor

   More actions

   Repository classes

   When they are not like that, we should move the repository implementations to a package called repository, and make the test classes in the same corresponding package.

   OCAppRegistryRepository:
   (No tests for this class currently)

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCAuthenticationRepository:
   Rename test methods to follow the convention, and place asserts before verify

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCCapabilityRepository:
   Some tests don't have verify, and they have to be reordered to keep the order of the implementation

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCFileRepository:
   We don't have tests for copyFile, getFileByIdAsFlow, getPersonalRootFolderForAccount, getSharesRootFolderForAccount, getSearchFolderContent, getFolderContentWithSyncInfoAsFlow, getSharedByLinkWithSyncInfoForAccountAsFlow, getFilesWithSyncInfoAvailableOfflineFromAccountAsFlow, getFilesAvailableOfflineFromAccount, getFilesAvailableOfflineFromEveryAccount, moveFile, readFile, renameFile, saveConflict, cleanConflict, saveDownloadWorkerUuid, cleanWorkersUuid, disableThumbnailsForFile, updateFileWithNewAvailableOfflineStatus, updateDownloadedFilesStorageDirectoryInStoragePath, and updateFileWithLastUsage

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCFolderBackupRepository:
   (No tests for this class currently)

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCOAuthRepository:
   Some tests don't have asserts

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCServerInfoRepository:
   The current test doesn't explore all the alternatives of the method tested, we need to add some more tests for that method

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCShareeRepository:
   Rename test methods to follow the convention, and add asserts

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCShareRepository:
   Rename test methods to follow the convention, reorder them and add verify

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCSpacesRepository:
   (No tests for this class currently)

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCTransferRepository:
   (No tests for this class currently)

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCUserRepository:
   Current tests don't have asserts, and we don't have tests for getAllUserQuotas

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes

   OCWebFingerRepository:
   (No tests for this class currently)

   • Check that every method returns the expected result
   • Verify that every method calls the corresponding methods of other classes
9. JuancaG05

   unassigned

   manuelplazaspalacio

   on Apr 12, 2024
10. JuancaG05

    unassigned

    Aitorbp

    on Oct 28, 2024