Visitar URL original
[FEATURE REQUEST] Review `avoidScreenshotsIfNeeded` usage · Issue #4996 · owncloud/android · GitHub
Skip to content

[FEATURE REQUEST] Review avoidScreenshotsIfNeeded usage #4996

Open

Description

@jesmrec
fun Dialog.avoidScreenshotsIfNeeded() {
    if (!BuildConfig.DEBUG && context.resources?.getBoolean(R.bool.allow_screenshots) == false) {
        window?.addFlags(WindowManager.LayoutParams.FLAG_SECURE)
    }

such method is used in several dialogs across the app. Some of them (like the remove share or remove member from space) do not seem to need to avoid screenshots

All the uses of the method should be reviewed to keep those that are really useful, and remove the ones that don't need avoidScreenshotsIfNeeded

TASKS

  • Research (if needed)
  • Create branch technical/remove_avoid_screenshots_method_from_dialogs
  • Development tasks
    • Implement whatever
    • ...
    • Implement unit tests (if needed)
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch technical/remove_avoid_screenshots_method_from_dialogs into master

Activity

  1. added this to the 4.9 - Current milestone on Oct 2, 2026
  2. self-assigned this
    on Oct 8, 2026
  3. joragua commented on Oct 8, 2026

    @joragua
    Member
    Image
  4. joragua commented on Oct 8, 2026

    @joragua
    Member

    Check #3596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions