Repository navigation
Versions downloaded of shared files are named with a number instead of the filename #36228
Description
Steps to reproduce
- create a file (e.g docx)
- Edit it and create a version
- Share the file with userB
- Login with userB
- Browse to the SideBar and download a file version
Expected behaviour
File's name should be preserved
Actual behaviour
Files is downloaded named as a number
Database:
MySQL
ownCloud version: (see ownCloud admin page)
oC 10 10.3.0RC1
Activity
phil-davis commentedon Jun 28, 2021
This is still an issue. As receiver of the shared file, I get an old version downloaded with a name like
1624854121.txtNote: As receiver of a shared folder, I can download old versions of files in the folder, and I get the correct file names.
The UI is sending a request to something like:
http://172.17.0.1:8080/remote.php/dav/meta/2147484945/v/1624854120
@dpakach someone should first check that there are API tests that cover this - I see that
FilesVersionsContext.phphas references to path/meta/$fileId/v- there need to be API tests that cover the share receiver downloading previous versions of a received file. (and downloading previous versions of a file that is in a received folder)And once we have API tests that we know are passing, then it might be a UI problem, and we can make a UI test that demonstrates this.
individual-it commentedon Jun 30, 2021
I think the issue is the
Content-DispositionHeaderdownloading a n older version of an own file gives:
attachment; filename*=UTF-8''block-aligned.txt; filename="block-aligned.txt"but in a shared case:
attachment; filename*=UTF-8''; filename=""individual-it commentedon Jun 30, 2021
I don't think we have any API tests trying to download old versions
individual-it commentedon Jul 8, 2021
tests added in #38921
AlexAndBear commentedon Sep 29, 2021
@JammingBen Still exists, should be name like in users file list (keep in mind, that the user can rename a shared file)
Merge pull request #39314 from /issues/36228