Visitar URL original
reload config issue · Issue #164 · pgpool/pgpool2 · GitHub
Skip to content

reload config issue #164

Description

@liujinyang-highgo

hi,
I met an issue ,could you help have a look at it?

reproduce:

  1. set parameter log_connections(default value is off) to on in ppgool.conf
    log_connections = on
  2. then use psql connect to pgpool and run show command.
    ppgool show log_connections;  
    log_connections 
   -----------------
    on
  1. \q and terminate the connection.
  2. comment this parameter in pgpool.conf.
    # log_connections = on
  3. do reload
    ./pgpool -f ../etc/pgpool.conf reload
  4. use psql connect to pgpool again and run show command.
    ppgool show log_connections;  
    log_connections 
   -----------------
    on

my concern:
for my understanding, in step 6, the result should be recovered to default value? right?
I checked code, when parent process received reload sig, it will send this sig to all child processes, then child call check_config_reload()->pool_get_config() to reload config file, but it will ignore commented lines in pgpool.conf, so the commented lines would not be recovered to default value.
I'm not quite sure if this is the original design intention.

Thanks a lot!

Activity

  1. koshino-235 commented on Jun 30, 2026

    @koshino-235
    Collaborator

    Hi,

    I can reproduce this behavior in my environment.

    Commenting out a parameter and reloading does not restore it to its default value.
    This is the current behavior.

    However, this is not the behavior the development team intended, and we're planning to fix it.

    As a workaround, either:

    • keep the parameter uncommented, set it explicitly to its default value, and reload.
    • comment it out and restart Pgpool-II so the default value is applied at startup.
  2. koshino-235 commented on Sep 3, 2026

    @koshino-235
    Collaborator

    Hi,
    I have created a patch to fix this issue.
    With this patch, commenting out a parameter in pgpool.conf and reloading Pgpool-II resets the parameter to its default value.
    I would appreciate it if you could apply the patch and verify that it works as expected in your environment.

    Best Regards,

    v4-0001-Fix-Reset-removed-config-parameters-to-defaults.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions