Visitar URL original
Revert "Move menuResizer related functions to menu-resizer.js" · phpmyadmin/phpmyadmin@9546a45 · GitHub
Skip to content

Commit 9546a45

Browse files
committed
Revert "Move menuResizer related functions to menu-resizer.js"
That commit broke the onload and teardown calls. Reverting fixes the tests. This reverts commit 5e6541e. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
1 parent dbcc8b2 commit 9546a45

8 files changed

Lines changed: 27 additions & 40 deletions

File tree

‎js/src/main.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import { PageSettings } from './modules/page_settings.js';
77
import { crossFramingProtection } from './modules/cross_framing_protection.js';
88
import { Indexes } from './modules/indexes.js';
99
import { Config } from './modules/config.js';
10-
import { initializeMenuResizer } from './modules/menu-resizer.js';
1110

1211
AJAX.registerOnload('main.js', () => AJAX.removeSubmitEvents());
1312
$(AJAX.loadEventHandler());
@@ -34,7 +33,7 @@ AJAX.registerTeardown('main.js', Functions.off());
3433
AJAX.registerOnload('main.js', Functions.on());
3534

3635
$(Functions.dismissNotifications());
37-
$(initializeMenuResizer());
36+
$(Functions.initializeMenuResizer());
3837
$(Functions.floatingMenuBar());
3938
$(Functions.breadcrumbScrollToTop());
4039

Lines changed: 1 addition & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import $ from 'jquery';
2-
import { Functions } from './functions.js';
2+
import { Functions } from './modules/functions.js';
33

44
/**
55
* Handles the resizing of a menu according to the available screen width
@@ -189,33 +189,3 @@ import { Functions } from './functions.js';
189189
}
190190
};
191191
}($));
192-
193-
/**
194-
* @return {void}
195-
*/
196-
function resizeTopMenu () {
197-
$('#topmenu').menuResizer('resize');
198-
}
199-
200-
/**
201-
* @return {void}
202-
*/
203-
function initializeTopMenuResizer () {
204-
$('#topmenu').menuResizer(() => $(document.body).width() - 5);
205-
}
206-
207-
/**
208-
* @return {function}
209-
*/
210-
function initializeMenuResizer () {
211-
return function () {
212-
// Initialise the menu resize plugin
213-
initializeTopMenuResizer();
214-
// register resize event
215-
$(window).on('resize', function () {
216-
resizeTopMenu();
217-
});
218-
};
219-
}
220-
221-
export { initializeMenuResizer, initializeTopMenuResizer, resizeTopMenu };

‎js/src/modules/ajax.js‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import $ from 'jquery';
22
import { Functions } from './functions.js';
33
import { Navigation } from './navigation.js';
44
import { CommonParams } from './common.js';
5-
import { initializeTopMenuResizer } from './menu-resizer.js';
65
import highlightSql from './sql-highlight.js';
76

87
/**
@@ -223,7 +222,7 @@ const AJAX = {
223222
// Remove duplicate wrapper
224223
// TODO: don't send it in the response
225224
.children().first().remove();
226-
initializeTopMenuResizer();
225+
$('#topmenu').menuResizer(Functions.mainMenuResizerCallback);
227226
}
228227
},
229228
/**

‎js/src/modules/functions.js‎

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import { Navigation } from './navigation.js';
44
import { CommonActions, CommonParams } from './common.js';
55
import { Indexes } from './indexes.js';
66
import { Config } from './config.js';
7-
import { resizeTopMenu } from './menu-resizer.js';
87
import tooltip from './tooltip.js';
98
import highlightSql from './sql-highlight.js';
109

@@ -3166,6 +3165,24 @@ Functions.showHints = function ($div) {
31663165
});
31673166
};
31683167

3168+
Functions.mainMenuResizerCallback = function () {
3169+
// 5 px margin for jumping menu in Chrome
3170+
// eslint-disable-next-line compat/compat
3171+
return $(document.body).width() - 5;
3172+
};
3173+
3174+
/**
3175+
* @return {function}
3176+
*/
3177+
Functions.initializeMenuResizer = () => function () {
3178+
// Initialise the menu resize plugin
3179+
$('#topmenu').menuResizer(Functions.mainMenuResizerCallback);
3180+
// register resize event
3181+
$(window).on('resize', function () {
3182+
$('#topmenu').menuResizer('resize');
3183+
});
3184+
};
3185+
31693186
/**
31703187
* var toggleButton This is a function that creates a toggle
31713188
* sliding button given a jQuery reference
@@ -3688,7 +3705,7 @@ Functions.floatingMenuBar = () => function () {
36883705
'padding-top',
36893706
$('#floating_menubar').outerHeight(true)
36903707
);
3691-
resizeTopMenu();
3708+
$('#topmenu').menuResizer('resize');
36923709
}, 4);
36933710
}
36943711
};

‎js/src/modules/navigation.js‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import $ from 'jquery';
22
import { Functions } from './functions.js';
33
import { CommonParams } from './common.js';
44
import { Config } from './config.js';
5-
import { resizeTopMenu } from './menu-resizer.js';
65
import tooltip from './tooltip.js';
76

87
/**
@@ -1195,7 +1194,7 @@ Navigation.ResizeHandler = function () {
11951194
this.mouseup = function (event) {
11961195
$('body').css('cursor', '');
11971196
Functions.configSet('NavigationWidth', event.data.resize_handler.getPos(event));
1198-
resizeTopMenu();
1197+
$('#topmenu').menuResizer('resize');
11991198
$(document)
12001199
.off('mousemove')
12011200
.off('mouseup');
@@ -1282,7 +1281,7 @@ Navigation.ResizeHandler = function () {
12821281
this.treeResize();
12831282
const callbackSuccessGetConfigValue = (data) => {
12841283
this.setWidth(data);
1285-
resizeTopMenu();
1284+
$('#topmenu').menuResizer('resize');
12861285
};
12871286
// Skip mobile
12881287
if (isLoadedOnMobile === false) {

‎libraries/classes/Header.php‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ private function addDefaultScripts(): void
140140
$this->scripts->addFile('vendor/jquery/jquery-ui-timepicker-addon.js');
141141
$this->scripts->addFile('index.php', ['route' => '/messages', 'l' => $GLOBALS['lang']]);
142142
$this->scripts->addFile('shared.js');
143+
$this->scripts->addFile('menu_resizer.js');
143144
$this->scripts->addFile('main.js');
144145

145146
$this->scripts->addCode($this->getJsParamsCode());

‎test/classes/HeaderTest.php‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,6 +262,7 @@ public function testAddedDefaultScripts(): void
262262
['name' => 'vendor/jquery/jquery-ui-timepicker-addon.js', 'fire' => 0],
263263
['name' => 'index.php', 'fire' => 0],
264264
['name' => 'shared.js', 'fire' => 0],
265+
['name' => 'menu_resizer.js', 'fire' => 1],
265266
['name' => 'main.js', 'fire' => 1],
266267
];
267268
$this->assertSame($expected, $scripts->getFiles());

‎webpack.config.cjs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ module.exports = [
4343
'jquery.sortable-table': './js/src/jquery.sortable-table.js',
4444
'main': './js/src/main.js',
4545
'makegrid': './js/src/makegrid.js',
46+
'menu_resizer': './js/src/menu_resizer.js',
4647
'multi_column_sort': './js/src/multi_column_sort.js',
4748
'name-conflict-fixes': './js/src/name-conflict-fixes.js',
4849
'normalization': './js/src/normalization.js',

0 commit comments

Comments
 (0)