Visitar URL original
Merge pull request #19767 from MauricioFauth/psr-container-stub · phpmyadmin/phpmyadmin@9b1e1b5 · GitHub
Skip to content

Commit 9b1e1b5

Browse files
Merge pull request #19767 from MauricioFauth/psr-container-stub
Add static analysis stub for PSR ContainerInterface
2 parents 4ccd84b + a82b8e2 commit 9b1e1b5

26 files changed

Lines changed: 43 additions & 44 deletions

‎.gitattributes‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
.gitattributes export-ignore
44
.gitignore export-ignore
55
.github export-ignore
6+
.phpstorm.meta.php export-ignore
67
.scrutinizer.yml export-ignore
78
.jshintrc export-ignore
89
.stylelintrc.json export-ignore

‎.phpstorm.meta.php‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
<?php
2+
3+
namespace PHPSTORM_META {
4+
override(\Psr\Container\ContainerInterface::get(0), map(['@']));
5+
}

‎app/services.php‎

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,8 @@
9999
'arguments' => ['@http_request', '@relation', '@template', '@config'],
100100
],
101101
'events' => ['class' => Events::class, 'arguments' => ['@dbi']],
102-
'export' => ['class' => Export::class, 'arguments' => ['@dbi']],
102+
Export::class => ['class' => Export::class, 'arguments' => ['@dbi']],
103+
'export' => Export::class,
103104
'export_options' => [
104105
'class' => Options::class,
105106
'arguments' => ['@relation', '@export_template_model'],
@@ -239,7 +240,8 @@
239240
'arguments' => ['$dbi' => '@dbi'],
240241
],
241242
AuthenticationPluginFactory::class => ['class' => AuthenticationPluginFactory::class],
242-
'relation' => ['class' => Relation::class, 'arguments' => ['$dbi' => '@dbi', '$config' => '@config']],
243+
Relation::class => ['class' => Relation::class, 'arguments' => ['$dbi' => '@dbi', '$config' => '@config']],
244+
'relation' => Relation::class,
243245
'relation_cleanup' => ['class' => RelationCleanup::class, 'arguments' => ['@dbi', '@relation']],
244246
'replication' => ['class' => Replication::class, 'arguments' => ['$dbi' => '@dbi']],
245247
'replication_gui' => [
@@ -293,7 +295,8 @@
293295
],
294296
'table_maintenance' => ['class' => PhpMyAdmin\Table\Maintenance::class, 'arguments' => ['$dbi' => '@dbi']],
295297
'table_search' => ['class' => Search::class, 'arguments' => ['$dbi' => '@dbi']],
296-
'template' => ['class' => Template::class, 'arguments' => ['$config' => '@config']],
298+
Template::class => ['class' => Template::class, 'arguments' => ['$config' => '@config']],
299+
'template' => Template::class,
297300
ThemeManager::class => ['class' => ThemeManager::class],
298301
'tracking' => [
299302
'class' => Tracking::class,
@@ -309,8 +312,8 @@
309312
'class' => TrackingChecker::class,
310313
'arguments' => ['$dbi' => '@dbi', '$relation' => '@relation'],
311314
],
312-
'transformations' => ['class' => Transformations::class, 'arguments' => ['@dbi', '@relation']],
313-
Transformations::class => 'transformations',
315+
Transformations::class => ['class' => Transformations::class, 'arguments' => ['@dbi', '@relation']],
316+
'transformations' => Transformations::class,
314317
'triggers' => ['class' => Triggers::class, 'arguments' => ['@dbi']],
315318
'user_password' => [
316319
'class' => UserPassword::class,

‎phpstan.neon.dist‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ parameters:
1313
bootstrapFiles:
1414
- tests/phpstan-constants.php
1515
stubFiles:
16+
- tests/stubs/psr.stub
1617
- tests/stubs/uploadprogress.stub
1718
excludePaths:
1819
- app/cache/*

‎psalm.xml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
</projectFiles>
3535

3636
<stubs>
37+
<file name="tests/stubs/psr.stub"/>
3738
<file name="tests/stubs/uploadprogress.stub"/>
3839
</stubs>
3940

‎src/Application.php‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@
5151
use Psr\Http\Message\ServerRequestInterface;
5252
use Throwable;
5353

54-
use function assert;
5554
use function sprintf;
5655

5756
readonly class Application
@@ -62,10 +61,7 @@ public function __construct(private ResponseFactory $responseFactory)
6261

6362
public static function init(): self
6463
{
65-
$application = ContainerBuilder::getContainer()->get(self::class);
66-
assert($application instanceof self);
67-
68-
return $application;
64+
return ContainerBuilder::getContainer()->get(self::class);
6965
}
7066

7167
public function run(bool $isSetupPage = false): void

‎src/Controllers/Export/ExportController.php‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,6 @@ public function __invoke(ServerRequest $request): Response
289289
Current::$message = Message::error(
290290
__('No tables found in database.'),
291291
);
292-
/** @var DatabaseExportController $controller */
293292
$controller = ContainerBuilder::getContainer()->get(DatabaseExportController::class);
294293

295294
return $controller($request);

‎src/Controllers/Table/IndexesController.php‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,6 @@ public function __invoke(ServerRequest $request): Response
159159
return $this->response->response();
160160
}
161161

162-
/** @var StructureController $controller */
163162
$controller = ContainerBuilder::getContainer()->get(StructureController::class);
164163

165164
return $controller($request);

‎src/Controllers/View/CreateController.php‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,6 @@ private function setSuccessResponse(array $view, bool $ajaxdialog, ServerRequest
219219

220220
if ($ajaxdialog) {
221221
Current::$message = Message::success();
222-
/** @var StructureController $controller */
223222
$controller = ContainerBuilder::getContainer()->get(StructureController::class);
224223

225224
return $controller($request);

‎src/Display/Results.php‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1117,7 +1117,6 @@ private function getFullOrPartialTextButtonOrLink(): string
11171117
$urlParamsFullText['pftext'] = self::DISPLAY_FULL_TEXT;
11181118
}
11191119

1120-
/** @var ThemeManager $themeManager */
11211120
$themeManager = ContainerBuilder::getContainer()->get(ThemeManager::class);
11221121

11231122
$tmpImage = '<img class="fulltext" src="'

0 commit comments

Comments
 (0)