Repository navigation
migrate rust language's addition-dependencies to use cargo install #3278
Description
Activity
What about installing pre-built binaries with
cargo binstallif available forcli:dependencies? That would make a lot of installations really faster.Reacted by Brendan, pravic and Benjamin BannierAgreed, but compatibility with cargo-binstall cannot be assumed/guaranteed. cargo-binstall support is largely a voluntary effort on behalf of developers and may actually fall under pre-commit's
systemlanguage.but compatibility with cargo-binstall cannot be assumed/guaranteed
And yet, pre-commit could detect
cargo-binstalland use it instead ofcargo install. Especially, given the fact thatbinstallfalls back to installing from source if a binary distribution isn't available.Reacted by João M. Martins and Benjamin Bannierbut compatibility with cargo-binstall cannot be assumed/guaranteed
And yet, pre-commit could detect
cargo-binstalland use it instead ofcargo install. Especially, given the fact thatbinstallfalls back to installing from source if a binary distribution isn't available.By "compatibility", I meant that the pre-commit hook's GitHub releases need to have assets that comply with cargo-binstall's strategy. Its probably not a big deal since cargo-binstall will fallback to
cargo installif 1the release asset is not present or 2quick-install repo hasn't built the version of the requested crate.FWIW, I use cargo-binstall wherever possible. Although, forcing it on end-users may not be an ideal approach. There's a provenance concern and privacy concern (about cargo-binstall's analytic data gathering) which should err toward building from sources hosted on crates.io by default. But, it would be nice if pre-commit hook authors could opt-in to using cargo-binstall.
Reacted by Louis MaddoxAlthough, forcing it on end-users may not be an ideal approach.
In case of using
precommitlocally, usingcargo-binstallis literally an opt-in. Because in order to be used, it needs to be installed first on the host machine.But I can't speak for GitHub actions - but at least they are parametrized, right? So, a GitHub action user could opt-in for
cargo-binstallas well.install / binstall is off topic for this issue -- this issue is about removing
cargo add
search you tried in the issue tracker
rust
describe your actual problem
This is following the discussion about allowing cargo features to be used in rust-based hooks (started in #3230 continued in #3235).
The
cargo addcommand has been used since 2018 to add dependencies to a rust-based hook's manifest (Cargo.toml). Sometime since then (probably when 2021 edition was stabalized), cargo features were implemented in thecargo installcommand. As noted in #3235 (comment), this makescargo installmore suitable for a rust-based hook'sadditional-dependenciesbecause it actually installs additionally specified dependencies.Tip
Using
--lockedbetter assures expected install behavior. However, this is not the default forcargo install.pre-commit --version
3.7.1