Repository navigation
Expand file tree
/
Copy pathfields_v1_test.go
More file actions
399 lines (335 loc) · 12.2 KB
/
Copy pathfields_v1_test.go
File metadata and controls
399 lines (335 loc) · 12.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
package publiccode
import (
"net/http"
"net/http/httptest"
"net/url"
"strings"
"testing"
)
func TestAsPublicCodeV1(t *testing.T) {
v1 := &PublicCodeV1{}
result := asPublicCode(v1)
if result == nil {
t.Fatal("asPublicCode returned nil for *PublicCodeV1")
}
if _, ok := result.(*PublicCodeV1); !ok {
t.Errorf("asPublicCode returned unexpected type: %T", result)
}
}
// TestValidateFieldsV1Direct calls validateFieldsV1 directly to cover its code paths
// without needing to add "1" to SupportedVersions.
func TestValidateFieldsV1Direct(t *testing.T) {
p, err := NewParser(ParserConfig{DisableNetwork: true, DisableExternalChecks: true})
if err != nil {
t.Fatalf("can't create parser: %v", err)
}
base := &url.URL{Scheme: "file", Path: "/tmp"}
raw, _ := url.Parse("https://github.com/example/repo.git")
u := (*URL)(raw)
locReady := true
v1 := &PublicCodeV1{
PubliccodeYamlVersion: "1",
Name: "Test",
URL: u,
Platforms: []string{"web"},
DevelopmentStatus: "stable",
SoftwareType: "standalone/web",
Description: map[string]DescV1{
"en": {
ShortDescription: "Short description.",
LongDescription: strings.Repeat("x", 151),
},
},
Legal: struct {
License string `json:"license" validate:"required,is_spdx_expression" yaml:"license"`
MainCopyrightOwner *string `json:"mainCopyrightOwner,omitempty" yaml:"mainCopyrightOwner,omitempty"`
}{License: "MIT"},
Maintenance: struct {
Type string `json:"type" validate:"required,oneof=internal contract community none" yaml:"type"`
Contractors *[]ContractorV1 `json:"contractors,omitempty" validate:"required_if=Type contract,excluded_unless=Type contract,omitempty,dive" yaml:"contractors,omitempty"`
Contacts *[]ContactV1 `json:"contacts,omitempty" validate:"required_if=Type community,required_if=Type internal,omitempty,dive" yaml:"contacts,omitempty"`
}{Type: "none"},
Localisation: struct {
LocalisationReady *bool `json:"localisationReady" validate:"required" yaml:"localisationReady"`
AvailableLanguages []string `json:"availableLanguages" validate:"required,gt=0,dive,bcp47_strict_language_tag" yaml:"availableLanguages"`
}{
LocalisationReady: &locReady,
AvailableLanguages: []string{"en"},
},
}
err = validateFieldsV1(v1, p, false, base)
if err != nil {
t.Errorf("unexpected error from validateFieldsV1: %v", err)
}
}
func TestValidateFieldsV1WithLogoAbsPath(t *testing.T) {
p, _ := NewParser(ParserConfig{DisableNetwork: true, DisableExternalChecks: false})
base := &url.URL{Scheme: "file", Path: "/tmp"}
logo := "/absolute/path/logo.svg"
locReady := true
v1 := &PublicCodeV1{
Logo: &logo,
Localisation: struct {
LocalisationReady *bool `json:"localisationReady" validate:"required" yaml:"localisationReady"`
AvailableLanguages []string `json:"availableLanguages" validate:"required,gt=0,dive,bcp47_strict_language_tag" yaml:"availableLanguages"`
}{
LocalisationReady: &locReady,
AvailableLanguages: []string{"en"},
},
}
err := validateFieldsV1(v1, p, false, base)
if err == nil {
t.Error("expected error for absolute logo path")
}
}
func TestValidateFieldsV1WithVideos(t *testing.T) {
p, _ := NewParser(ParserConfig{DisableNetwork: true, DisableExternalChecks: true})
base := &url.URL{Scheme: "file", Path: "/tmp"}
videoURL, _ := url.Parse("https://www.invalid-video-url.example.com/watch?v=abc")
v := (*URL)(videoURL)
v1 := &PublicCodeV1{
Description: map[string]DescV1{
"en": {
Videos: []*URL{v},
},
},
}
err := validateFieldsV1(v1, p, false, base)
if err == nil {
t.Error("expected error for invalid oEmbed video URL")
}
}
func TestValidateFieldsV1WithScreenshotAbsPath(t *testing.T) {
p, _ := NewParser(ParserConfig{DisableNetwork: true, DisableExternalChecks: false})
base := &url.URL{Scheme: "file", Path: "/tmp"}
v1 := &PublicCodeV1{
Description: map[string]DescV1{
"en": {
Screenshots: []string{"/absolute/path/screen.png"},
},
},
}
err := validateFieldsV1(v1, p, false, base)
if err == nil {
t.Error("expected error for absolute path screenshot")
}
}
func TestValidateFieldsV1WithScreenshotRelative(t *testing.T) {
p, _ := NewParser(ParserConfig{DisableNetwork: true, DisableExternalChecks: false})
base := &url.URL{Scheme: "file", Path: "/tmp"}
v1 := &PublicCodeV1{
Description: map[string]DescV1{
"en": {
Screenshots: []string{"assets/screen.png"},
},
},
}
// Should not panic, may produce an error about missing file
_ = validateFieldsV1(v1, p, false, base)
}
func TestValidateFieldsV1WithNetworkChecks(t *testing.T) {
// Use a test server that returns 200 so we can exercise the IsRepo check path,
// but the URL is not a code repository.
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(http.StatusOK)
}))
defer srv.Close()
p, _ := NewParser(ParserConfig{DisableNetwork: false, DisableExternalChecks: false, AllowNetworkToPrivateHosts: true})
base := &url.URL{Scheme: "file", Path: "/tmp"}
// srv.URL is not a code repo, so IsRepo should return false
rawURL, _ := url.Parse(srv.URL + "/not-a-repo")
u := (*URL)(rawURL)
landingRaw, _ := url.Parse(srv.URL + "/landing")
landing := (*URL)(landingRaw)
roadmapRaw, _ := url.Parse(srv.URL + "/roadmap")
roadmap := (*URL)(roadmapRaw)
docRaw, _ := url.Parse(srv.URL + "/docs")
docURL := (*URL)(docRaw)
apiDocRaw, _ := url.Parse(srv.URL + "/api-docs")
apiDoc := (*URL)(apiDocRaw)
v1 := &PublicCodeV1{
URL: u,
LandingURL: landing,
Roadmap: roadmap,
Description: map[string]DescV1{
"en": {
Documentation: docURL,
APIDocumentation: apiDoc,
},
},
}
// network=true, checksNetwork=true
err := validateFieldsV1(v1, p, true, base)
// We expect the "not a valid code repository" error.
if err == nil {
t.Log("no error (URL might have been checked differently)")
}
}
func TestValidateFieldsV1WithUnreachableURLs(t *testing.T) {
// Use a test server that returns 404 so we can exercise the not-reachable paths.
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
http.Error(w, "not found", http.StatusNotFound)
}))
defer srv.Close()
p, _ := NewParser(ParserConfig{DisableNetwork: false, DisableExternalChecks: false, AllowNetworkToPrivateHosts: true})
base := &url.URL{Scheme: "file", Path: "/tmp"}
rawURL, _ := url.Parse(srv.URL + "/repo.git")
u := (*URL)(rawURL)
landingRaw, _ := url.Parse(srv.URL + "/landing")
landing := (*URL)(landingRaw)
roadmapRaw, _ := url.Parse(srv.URL + "/roadmap")
roadmap := (*URL)(roadmapRaw)
v1 := &PublicCodeV1{
URL: u,
LandingURL: landing,
Roadmap: roadmap,
}
docRaw, _ := url.Parse(srv.URL + "/docs")
docURL := (*URL)(docRaw)
v1.Description = map[string]DescV1{
"en": {Documentation: docURL},
}
// network=true, checksNetwork=true
err := validateFieldsV1(v1, p, true, base)
// We expect errors because the URLs return 404.
if err == nil {
t.Error("expected errors for unreachable URLs")
}
}
func TestValidateFieldsV1WithAPIDocNetworkCheck(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
http.Error(w, "not found", http.StatusNotFound)
}))
defer srv.Close()
p, _ := NewParser(ParserConfig{AllowNetworkToPrivateHosts: true})
base := &url.URL{Scheme: "file", Path: "/tmp"}
apiDocRaw, _ := url.Parse(srv.URL + "/api-docs")
apiDoc := (*URL)(apiDocRaw)
v1 := &PublicCodeV1{
Description: map[string]DescV1{
"en": {
APIDocumentation: apiDoc,
},
},
}
err := validateFieldsV1(v1, p, true, base)
if err == nil {
t.Error("expected error for unreachable API documentation URL")
}
}
func TestValidateFieldsV1WithCountriesDeprecated(t *testing.T) {
p, _ := NewParser(ParserConfig{DisableNetwork: true, DisableExternalChecks: true})
base := &url.URL{Scheme: "file", Path: "/tmp"}
countries := []string{"it"} // lowercase - deprecated
unsupported := []string{"de"} // lowercase - deprecated
locReady := true
v1 := &PublicCodeV1{
IntendedAudience: &struct {
Scope *[]string `json:"scope,omitempty" validate:"omitempty,dive,is_scope_v0" yaml:"scope,omitempty"`
Countries *[]string `json:"countries,omitempty" validate:"omitempty,dive,iso3166_1_alpha2_lower_or_upper" yaml:"countries,omitempty"`
UnsupportedCountries *[]string `json:"unsupportedCountries,omitempty" validate:"omitempty,dive,iso3166_1_alpha2_lower_or_upper" yaml:"unsupportedCountries,omitempty"`
}{
Countries: &countries,
UnsupportedCountries: &unsupported,
},
Localisation: struct {
LocalisationReady *bool `json:"localisationReady" validate:"required" yaml:"localisationReady"`
AvailableLanguages []string `json:"availableLanguages" validate:"required,gt=0,dive,bcp47_strict_language_tag" yaml:"availableLanguages"`
}{
LocalisationReady: &locReady,
AvailableLanguages: []string{"en"},
},
}
err := validateFieldsV1(v1, p, false, base)
if err == nil {
t.Error("expected deprecation warnings for lowercase countries")
}
}
func TestValidateFieldsV0MonochromeLogoAbsPath(t *testing.T) {
p, _ := NewParser(ParserConfig{DisableNetwork: true, DisableExternalChecks: false})
base := &url.URL{Scheme: "file", Path: "/tmp"}
logo := "/absolute/mono.svg"
v0 := &PublicCodeV0{}
v0.MonochromeLogo = &logo
err := validateFieldsV0(v0, p, false, base)
vr, ok := err.(ValidationResults)
if !ok {
t.Fatal("expected ValidationResults")
}
found := false
for _, e := range vr {
if ve, ok := e.(ValidationError); ok && ve.Key == "monochromeLogo" {
found = true
}
}
if !found {
t.Error("expected monochromeLogo validation error for absolute path")
}
}
func TestValidateFieldsV0AuthorsFileAbsPath(t *testing.T) {
p, _ := NewParser(ParserConfig{DisableNetwork: true, DisableExternalChecks: false})
base := &url.URL{Scheme: "file", Path: "/tmp"}
authorsFile := "/absolute/AUTHORS"
v0 := &PublicCodeV0{}
v0.Legal.AuthorsFile = &authorsFile
err := validateFieldsV0(v0, p, false, base)
vr, ok := err.(ValidationResults)
if !ok {
t.Fatal("expected ValidationResults")
}
found := false
for _, e := range vr {
if ve, ok := e.(ValidationError); ok && ve.Key == "legal.authorsFile" {
found = true
}
}
if !found {
t.Error("expected legal.authorsFile validation error for absolute path")
}
}
func TestValidateFieldsV0ScreenshotsAbsPath(t *testing.T) {
p, _ := NewParser(ParserConfig{DisableNetwork: true, DisableExternalChecks: false})
base := &url.URL{Scheme: "file", Path: "/tmp"}
v0 := &PublicCodeV0{
Description: map[string]DescV0{
"en": {Screenshots: []string{"/absolute/screen.png"}},
},
}
err := validateFieldsV0(v0, p, false, base)
vr, ok := err.(ValidationResults)
if !ok {
t.Fatal("expected ValidationResults")
}
found := false
for _, e := range vr {
if ve, ok := e.(ValidationError); ok && strings.Contains(ve.Key, "screenshots") {
found = true
}
}
if !found {
t.Error("expected screenshots validation error for absolute path")
}
}
func TestValidateFieldsV1LogoRelativeExternalChecks(t *testing.T) {
// A valid relative path with DisableExternalChecks=false exercises the
// external check path for v1 logo (the else-if branch after isRelativePathOrURL).
p, _ := NewParser(ParserConfig{DisableNetwork: true, DisableExternalChecks: false})
base := &url.URL{Scheme: "file", Path: "/tmp"}
logo := "logo.svg" // relative path, passes isRelativePathOrURL
locReady := true
v1 := &PublicCodeV1{
Logo: &logo,
Localisation: struct {
LocalisationReady *bool `json:"localisationReady" validate:"required" yaml:"localisationReady"`
AvailableLanguages []string `json:"availableLanguages" validate:"required,gt=0,dive,bcp47_strict_language_tag" yaml:"availableLanguages"`
}{
LocalisationReady: &locReady,
AvailableLanguages: []string{"en"},
},
}
// /tmp/logo.svg does not exist, so validLogo should produce an error
err := validateFieldsV1(v1, p, false, base)
if err == nil {
t.Error("expected error for missing logo file")
}
}