Repository navigation
Commit ace9010
authored
Record removed scheduling.k8s.io group/versions and detect future removals (#4585)
Adds the `scheduling.k8s.io/v1alpha1` `Workload`/`WorkloadList`
lifecycle entries that #4570 missed. Without them `RemovedAPIVersion`
reports the group/version as still live, so applying one against a 1.36+
cluster hits a retry timeout with a generic API error instead of the
actionable removal message.
The upgrade workflow now diffs the group/version directories of the old
and new `k8s.io/api`. When Kubernetes removed something, it appends the
list and the two required hand edits to the generated PR body and fails
the run, so the bump still opens a PR but cannot merge unnoticed.
## Test plan
- `go test ./pkg/kinds/...` passes; deleting either new entry fails the
added test under both the full and truncated group spellings.
- Detection checked against the real modules: `v0.35.0` to `v0.36.0`
reports `scheduling/v1alpha1`, and `v0.36.3` to `v0.37.0` reports
`scheduling/v1alpha2`. The two `autoscaling` betas it also reports for
1.36 already have entries, so it is not over-reporting.
- `actionlint` and `golangci-lint` clean.1 parent aaf05e0 commit ace9010
2 files changed
Lines changed: 42 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
90 | 93 | | |
91 | 94 | | |
92 | 95 | | |
| |||
130 | 133 | | |
131 | 134 | | |
132 | 135 | | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
133 | 158 | | |
134 | 159 | | |
135 | 160 | | |
| |||
144 | 169 | | |
145 | 170 | | |
146 | 171 | | |
147 | | - | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
148 | 185 | | |
149 | 186 | | |
150 | 187 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
165 | 165 | | |
166 | 166 | | |
167 | 167 | | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
168 | 172 | | |
169 | 173 | | |
170 | 174 | | |
| |||
0 commit comments