9.2.0: INTERNALERROR "'cache/lastfailed' is not allowed to escape the cache directory" when cache_dir contains ".." #15295

Description

Since 9.2.0, pytest crashes at startup with an INTERNALERROR when the cache directory path contains a .. segment. This happens even though the key being looked up (cache/lastfailed) stays inside the cache directory.

A common way to hit this is tox with a toxworkdir outside the tox.ini directory (e.g. toxworkdir=../.tox). pytest defaults cache_dir to $TOX_ENV_DIR/.pytest_cache, and tox passes the .. through verbatim (/repo/cli/../.tox/py312). We hit it in https://github.com/aws/aws-parallelcluster/actions/runs/40766983823/job/123093652689?pr=7688, where every pytest job started failing once 9.2.0 was released.

INTERNALERROR>   File ".../_pytest/cacheprovider.py", line 334, in __init__
INTERNALERROR>     for k, v in config.cache.get("cache/lastfailed", {}).items()
INTERNALERROR>   File ".../_pytest/cacheprovider.py", line 214, in get
INTERNALERROR>     path = self._getvaluepath(key)
INTERNALERROR>   File ".../_pytest/cacheprovider.py", line 199, in _getvaluepath
INTERNALERROR>     return self._join_within(self._cachedir / self._CACHE_PREFIX_VALUES, key)
INTERNALERROR>   File ".../_pytest/cacheprovider.py", line 175, in _join_within
INTERNALERROR>     raise ValueError(f"{name!r} is not allowed to escape the cache directory")
INTERNALERROR> ValueError: 'cache/lastfailed' is not allowed to escape the cache directory

Minimal reproducer

mkdir -p proj/sub && cd proj/sub
echo 'def test_ok(): pass' > test_a.py
printf '[pytest]\ncache_dir = ../.pytest_cache\n' > pytest.ini
pytest -q

• pytest 9.1.1: 1 passed
• pytest 9.2.0: INTERNALERROR> ValueError: 'cache/lastfailed' is not allowed to escape the cache directory

You get the same failure without an ini file:

TOX_ENV_DIR="$PWD/../.tox/py312" pytest -q

Cause

The containment check added in #14884 (Cache._join_within) normalizes the joined path but not base:

path = Path(os.path.normpath(base.joinpath(name)))
if not path.is_relative_to(base):
    raise ValueError(...)

When base is /proj/sub/../.pytest_cache/v, path becomes /proj/.pytest_cache/v/cache/lastfailed. That is no longer lexically relative to the un-normalized base, so every key is rejected. cache_dir_from_config() / resolve_from_str() don't normalize the configured path either.

Suggested fix

Normalize base the same way before the comparison:

base = Path(os.path.normpath(base))
path = Path(os.path.normpath(base.joinpath(name)))

Alternatively, normalize _cachedir once when the Cache is created. With the one-line change applied locally, the reproducer passes and --lf works. Escaping keys (../escape, /abs/key, a/../../escape) are still rejected, and a .. that cancels out (a/../b) still works.

Environment

• pytest 9.2.0 (works on 9.1.1)
• Python 3.10–3.14 on ubuntu-latest (GitHub Actions); reproduced locally with Python 3.12.10 on macOS 26.7.1
• tox 4.67.4 (for the tox variant)