Repository navigation
Add tests label for changes in test.support helpers #679
Description
Activity
- changed the title
[-]Add `tests` label if a change happened to a `test.support` helper[/-][+]Add `tests` label for changes in `test.support` helpers[/+]on Dec 7, 2025 Maybe a glob for
Lib/test/**.pyon top of the^(test_|_test)heuristics?Most PRs for library/core etc will hopefully include tests. For those, tests are incidental rather than the focus.
How can we automatically identify PRs for which the primary focus is tests, rather than tests as a part of some other part of the project?
A
Most PRs for library/core etc will hopefully include tests. For those, tests are incidental rather than the focus.
If there is a change outside of tests, the loop will return early, and the
testslabel won't be applied. I'm just extending the heuristic to include matching files that don't start withtest_|_testbut are still in thetest/directory.How can we automatically identify PRs for which the primary focus is tests, rather than tests as a part of some other part of the project?
This is already handled by the loop.
I don't follow. This is an issue, not a PR?
My question was on semantics - if we have a PR that only changes test_pathlib, should that have the tests label or the library label? I'd say the latter is more relevant. How should bedevere make such judgments?
A
Sorry, I misunderstood. If we constrain this to just
Lib/test/support/**glob (maybe without the.py), that would surely solve the problem. Right?
Example: python/cpython#142370