Repository navigation
inspect.ismethoddescriptor(): lack of __delete__() is not checked #120381
Description
Bug report
Bug description:
The inspect.ismethoddescriptor() function reports descriptor objects which implement __delete__() but not __set__() as method descriptors, even though they are, in fact, data descriptors:
Actual behavior example:
>>> import inspect
>>> class Descriptor:
... def __get__(self, *_): pass
... def __delete__(self, *_): pass # Note: `__set__()` *not* defined.
...
>>> inspect.ismethoddescriptor(Descriptor()) # Wrong result:
TrueExpected result:
>>> inspect.ismethoddescriptor(Descriptor()) # Correct result:
FalseThere is an additional question: to which Python versions should the fix be applied?
IMHO, the fix can be safely applied to the branches 3.14 (main) and 3.13 (still in the beta phase). Backporting it to the earlier versions might be considered too disruptive. Obviously, the decision will need to be made by a core developer, not me.
CPython versions tested on:
3.8, 3.9, 3.10, 3.11, 3.12, 3.13, CPython main branch
Activity
pythongh-120381: Fix inspect.ismethoddescriptor()
gh-120381: Fix inspect.ismethoddescriptor() (#120383)
pythongh-120381: Fix inspect.ismethoddescriptor() (pythonGH-120383)
[3.13] gh-120381: Fix inspect.ismethoddescriptor() (GH-120684)
ncoghlan commentedon Jun 19, 2024
Merged and fixed for the next 3.13 beta. Thanks for the report and PR, @zuo!
pythongh-120381: Fix inspect.ismethoddescriptor() (python#120383)
zuo commentedon Jun 19, 2024
Thank you too! :)
pythongh-120381: Fix inspect.ismethoddescriptor() (python#120383)
pythongh-120381: Fix inspect.ismethoddescriptor() (python#120383)
pythongh-120381: Fix inspect.ismethoddescriptor() (python#120383)