Add tests for CLI of the tabnanny module

@vstinner

BPO	19102
Nosy	@vstinner, @berkerpeksag, @serhiy-storchaka, @ultimatecoder
PRs	gh-63301: Set exit code when tabnanny CLI exits on error #7699
Files	test_tabnanny.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/berkerpeksag'
closed_at = None
created_at = <Date 2013-09-27.11:41:08.119>
labels = ['type-feature', 'tests']
title = 'Add tests for CLI of the tabnanny module'
updated_at = <Date 2018-06-15.04:34:31.033>
user = 'https://github.com/berkerpeksag'

bugs.python.org fields:

activity = <Date 2018-06-15.04:34:31.033>
actor = 'jaysinh.shukla'
assignee = 'berker.peksag'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2013-09-27.11:41:08.119>
creator = 'berker.peksag'
dependencies = []
files = ['31882']
hgrepos = []
issue_num = 19102
keywords = ['patch']
message_count = 6.0
messages = ['198467', '230733', '233642', '319502', '319503', '319584']
nosy_count = 5.0
nosy_names = ['vstinner', 'berker.peksag', 'Al.Sweigart', 'serhiy.storchaka', 'jaysinh.shukla']
pr_nums = ['7699']
priority = 'low'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue19102'
versions = ['Python 3.5']

I was trying to use the argparse module instead of getopt and I couldn't find any tests for CLI of the tabnanny module.

Added comments on Rietveld.

Although tabnanny is located in the Lib directory, not in the Tools directory, technically it is a script. May be move test_tabnanny.py to Lib/test/test_tools?

Since tabnanny is also a module in the standard library (it is imported by the idle code), wouldn't moving it to lib/test/test_tools make it un-importable? This would be a good case for leaving it where it is.

@Jaysinh

New changeset dfa9643 by Victor Stinner (Jaysinh Shukla) in branch 'master':
bpo-19382: Adding test cases for module tabnanny (GH-851)
dfa9643

--

@Jaysinh Shukla: I looked at Berker's old patch, and I think that it would be interesting to modify tabnanny to return with a non-zero exit code in case of failure. Maybe replace "return" with "sys.exit(1)" after errprint() calls.

@Stinner

@Stinner Victor Thanks for merging. I will try to observe that patch and will update you here. Have a great day

@vstinner

@vstinner I have created the PR here. I wasn't sure so linked the PR with this issue. Thanks!

PR URL: #7699

gh-63301: Set exit code when tabnanny CLI exits on error (#7699)

pythongh-63301: Set exit code when tabnanny CLI exits on error (pytho…

Merge branch 'main' into nodeaddict

Merge branch 'main' into inlinecomp2

Navigation Menu

Repository navigation

Add tests for CLI of the tabnanny module #63301

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Add tests for CLI of the tabnanny module #63301

Description

Activity

berkerpeksag commented on Sep 27, 2013

serhiy-storchaka commented on Nov 6, 2014

AlSweigart commented on Jan 8, 2015

vstinner commented on Jun 14, 2018

ultimatecoder commented on Jun 14, 2018

ultimatecoder commented on Jun 15, 2018

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions