Repository navigation
Make Profile.print_stats support sorting by mutiple values #69990
Description
| BPO | 25804 |
|---|---|
| Nosy | @birkenfeld, @JelleZijlstra, @DanielNoord |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = None
closed_at = None
created_at = <Date 2015-12-05.08:25:52.232>
labels = ['type-feature', 'library']
title = 'Make Profile.print_stats support sorting by mutiple values'
updated_at = <Date 2022-03-16.08:34:17.207>
user = 'https://bugs.python.org/wdv4758h'bugs.python.org fields:
activity = <Date 2022-03-16.08:34:17.207>
actor = 'danielnoord'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2015-12-05.08:25:52.232>
creator = 'wdv4758h'
dependencies = []
files = ['41247', '41249']
hgrepos = []
issue_num = 25804
keywords = ['patch']
message_count = 5.0
messages = ['255935', '255940', '255952', '267273', '415329']
nosy_count = 5.0
nosy_names = ['georg.brandl', 'SilentGhost', 'wdv4758h', 'JelleZijlstra', 'danielnoord']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'test needed'
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue25804'
versions = ['Python 3.6']
Activity
wdv4758h commentedon Dec 5, 2015
Currently, the result of profile.run can not easily sort by mutiple values with "sort" keyword argument. Following code will work with this patch.
Ordered by: internal time, standard name
ncalls tottime percall cumtime percall filename:lineno(function)
1 0.000 0.000 0.000 0.000 {built-in method builtins.exec}
1 0.000 0.000 0.000 0.000 <string>:1(<module>)
1 0.000 0.000 0.000 0.000 {method 'disable' of '_lsprof.Profiler' objects}
Ordered by: internal time, standard name
ncalls tottime percall cumtime percall filename:lineno(function)
1 0.000 0.000 0.000 0.000 {built-in method builtins.exec}
1 0.000 0.000 0.000 0.000 <string>:1(<module>)
1 0.000 0.000 0.000 0.000 {method 'disable' of '_lsprof.Profiler' objects}
Ordered by: internal time, standard name
ncalls tottime percall cumtime percall filename:lineno(function)
1 0.000 0.000 0.000 0.000 profile:0(42**42)
1 0.000 0.000 0.000 0.000 :0(exec)
1 0.000 0.000 0.000 0.000 :0(setprofile)
1 0.000 0.000 0.000 0.000 <string>:1(<module>)
0 0.000 0.000 profile:0(profiler)
SilentGhost commentedon Dec 5, 2015
It would be good to add test for this.
wdv4758h commentedon Dec 5, 2015
Attached refactored patch with tests.
JelleZijlstra commentedon Jun 4, 2016
Patch looks good to me
DanielNoord commentedon Mar 16, 2022
@wdv4758h, do you think you will be able to resubmit the patch to Github? This would probably still be a useful addition and some review has already been done.
If not, I could pick up the patch and re-submit, but I don't want to take credit for your work unnecessarily.
furkanonder commentedon May 22, 2023
The PR is ready for review.
gh-69990: Make Profile.print_stats support sorting by multiple values (…
pythongh-69990: Make Profile.print_stats support sorting by multiple …
pythongh-69990: Make Profile.print_stats support sorting by multiple …
pythongh-69990: Make Profile.print_stats support sorting by multiple …