Visitar URL original
[sqlite3] don't combine error checks when adding integer constants · Issue #89797 · python/cpython · GitHub
Skip to content

[sqlite3] don't combine error checks when adding integer constants #89797

Description

@erlend-aasland
BPO 45634
Nosy @corona10, @erlend-aasland
PRs
  • bpo-45634: Don't combine error checks when adding sqlite3 int constants #29251
  • [3.10] bpo-45634: Don't combine error checks when adding sqlite3 int constants (GH-29251) #29343
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2021-10-31.17:22:04.676>
    created_at = <Date 2021-10-27.21:02:56.704>
    labels = ['extension-modules', '3.10', '3.11']
    title = "[sqlite3] don't combine error checks when adding integer constants"
    updated_at = <Date 2021-10-31.17:22:04.675>
    user = 'https://github.com/erlend-aasland'

    bugs.python.org fields:

    activity = <Date 2021-10-31.17:22:04.675>
    actor = 'erlendaasland'
    assignee = 'none'
    closed = True
    closed_date = <Date 2021-10-31.17:22:04.676>
    closer = 'erlendaasland'
    components = ['Extension Modules']
    creation = <Date 2021-10-27.21:02:56.704>
    creator = 'erlendaasland'
    dependencies = []
    files = []
    hgrepos = []
    issue_num = 45634
    keywords = ['patch']
    message_count = 4.0
    messages = ['405124', '405396', '405400', '405409']
    nosy_count = 2.0
    nosy_names = ['corona10', 'erlendaasland']
    pr_nums = ['29251', '29343']
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue45634'
    versions = ['Python 3.10', 'Python 3.11']

    Activity

    1. erlend-aasland commented on Oct 27, 2021

      @erlend-aasland
      ContributorAuthor

      In Modules/_sqlite/module.c, add_integer_constants() accumulates the return values of repeated PyModule_AddIntMacro() calls. We should change this to instead bailing immediately on error.

    2. corona10 commented on Oct 31, 2021

      @corona10
      Member

      New changeset 39b4d59 by Erlend Egeberg Aasland in branch 'main':
      bpo-45634: Don't combine error checks when adding sqlite3 int constants (GH-29251)
      39b4d59

    3. corona10 commented on Oct 31, 2021

      @corona10
      Member

      New changeset ed91f95 by Erlend Egeberg Aasland in branch '3.10':
      [3.10] bpo-45634: Don't combine error checks when adding sqlite3 int constants (GH-29251). (GH-29343)
      ed91f95

    4. erlend-aasland commented on Oct 31, 2021

      @erlend-aasland
      ContributorAuthor

      Thanks for reviewing, Dong-hee!

    5. transferred this issue fromon Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions