Repository navigation
syslog issues #95041
Description
Activity
- added a commit that references this issue
on Jul 20, 2022 - added a commit that references this issue
on Jul 26, 2022 I'm keeping this open until you decide about the NEWS entry, Serhiy. I'll mark it pending close, though.
Fixed by:
- gh-95041: Fix several minor issues in syslog.openlog() #95058
- [3.11] gh-95041: Fix several minor issues in syslog.openlog() (GH-95058) #95261
- [3.10] gh-95041: Fix several minor issues in syslog.openlog() (GH-95058) #95262
- gh-95041: Fail syslog.syslog in case inner call to syslog.openlog fails #95264
- [3.10] gh-95041: Fail syslog.syslog in case inner call to syslog.openlog fails (GH-95264) #95275
- [3.11] gh-95041: Fail syslog.syslog in case inner call to syslog.openlog fails (GH-95264) #95277
(Ooops, sorry; pressed the wrong button)
We kept this open based on #95264 (comment)
It looks like Serhiy added the tests in #97953 but chose not to add a changelog entry, so I think we can close this out.
Reacted by Noam Cohen
There are several issues with corner cases in
syslog.openlog().syslog_get_argv()swallows exceptions, but not in all cases.identis non UTF-8 encodable,syslog.openlog()fails after setting the global reference toident. Now the C string saved internally in the previous call toopenlog()points to the freed memory.PySys_Audit()can crash ifidentis NULL.syslog.syslog(), because the global reference toidentis decrefed before setting the new value.And, since
syslog.syslog()releases the GIL, there may be a race conditionsyslog.syslog()withsyslog.openlog()andsyslog.closelog()which can decref the global reference toident.P.S. @noamcohen97 noticed yet one issue in
syslog.syslog()(potential returning a value from a function while an exception is set #95012 (comment)) and fixed it.