Visitar URL original
test_tar test_add_dir_getmember fails if uid/gid is larger than 16777215 · Issue #95675 · python/cpython · GitHub
Skip to content

test_tar test_add_dir_getmember fails if uid/gid is larger than 16777215 #95675

Closed
Closed
test_tar test_add_dir_getmember fails if uid/gid is larger than 16777215#95675
Assignees
corona10uyw4687
Labels
3.10 (EOL)end of life3.11only security fixes3.12only security fixestestsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

Description

@colesbury
colesbury
opened on Aug 4, 2022

Bug report

The test_add_dir_getmember added in #30283 fails if the current user's uid or gid is larger than 16777215 because of limitations of UStar format.

Note that the other test cases don't have this problem.

This test should either avoid depending on the current user's uid/gid (such as by using an explicit uid/gid) or be skipped if the current uid/gid is 8**8 or larger.

For example,

def filter(tarinfo):
 tarinfo.uid = 100
 tarinfo.gid = 100
 return tarinfo

...
tar.add(name, filter=filter)

Will use 100 as the uid and gid instead of the current user's uid/gid.

Linked PRs

Activity

  1. colesbury
    added
    type-bugAn unexpected behavior, bug, or error
    testsTests in the Lib/test dir
    3.11only security fixes
    3.10 (EOL)end of life
    3.9 (EOL)end of life
    3.12only security fixes
    on Aug 4, 2022

  2. corona10 commented on Feb 18, 2023

    @corona10
    corona10
    on Feb 18, 2023
    Member

    @colesbury
    I will try to introduce this issue into the internal OSS sprint as the good first bug.
    I will delegate the issue to my mentees.

  3. corona10
    self-assigned this
    on Feb 18, 2023

  4. uyw4687 commented on Feb 20, 2023

    @uyw4687
    uyw4687
    on Feb 20, 2023
    Contributor

    I'll take it :)

  5. corona10
    assigned
    uyw4687
    on Feb 20, 2023
  6. uyw4687
    added 2 commits that reference this issue on Feb 24, 2023

    pythongh-95675 fix uid and gid at test_add_dir_getmember

    f9deb31

    pythongh-95675 Skip if getuid or getgid is not in os

    0704ec8
  7. corona10
    added a commit that references this issue on Feb 25, 2023

    gh-95675: fix uid and gid at test_add_dir_getmember (gh-102207)

    56e93c8
  8. miss-islington
    added 2 commits that reference this issue on Feb 25, 2023

    pythongh-95675: fix uid and gid at test_add_dir_getmember (pythongh-1…

    b5d9ef4

    pythongh-95675: fix uid and gid at test_add_dir_getmember (pythongh-1…

    1b9e917
  9. corona10
    removed
    3.9 (EOL)end of life
    on Feb 25, 2023
  10. corona10
    added 2 commits that reference this issue on Feb 25, 2023

    [3.11] gh-95675: fix uid and gid at test_add_dir_getmember (gh-102207) (

    9da3e7f

    [3.10] gh-95675: fix uid and gid at test_add_dir_getmember (gh-102207) (

    3e80d21
  11. corona10
    closed this as completedon Feb 25, 2023

  12. corona10 commented on Feb 25, 2023

    @corona10
    corona10
    on Feb 25, 2023
    Member

    Thank you @uyw4687!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

3.10 (EOL)end of life3.11only security fixes3.12only security fixestestsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions