Subclasses of ExceptionGroup can wrap BaseExceptions

@iritkatriel

class MyEG(ExceptionGroup):
    """Holds BaseExceptions without itself being a BaseException."""

oops = MyEG("oops", [KeyboardInterrupt()])
assert isinstance(oops, Exception)
assert not isinstance(oops.exceptions[0], Exception)

I believe that this is a bug tracing to the period when PEP-654 did not intend (Base)ExceptionGroup to be usable as a parent class; and I think a sufficient fix would be to replace the type-equality check with an isinstance check in:

cpython/Objects/exceptions.c

Lines 740 to 744 in bc390dd

    
           if (cls == PyExc_ExceptionGroup) { 
        
               if (nested_base_exceptions) { 
        
                   PyErr_SetString(PyExc_TypeError, 
        
                       "Cannot nest BaseExceptions in an ExceptionGroup"); 
        
                   goto error;

cc @iritkatriel; raised via agronholm/exceptiongroup#40 (comment)

Linked PRs

@gvanrossum

I believe we discussed this and decided that we leave it to the subclass author to deal with it. Maybe it needs to be documented (or reconsidered)?

CC @gvanrossum @1st1

I think at least documented, though I'd prefer it was changed.

If people intend MyEG to contain BaseExceptions then the obvious way is to inherit from BaseExceptionGroup (and likely have a BaseMyEg; Trio has already shipped this pattern), so any cases where MyEG ends up containing e.g. a KeyboardInterrupt and then discarding that to an except Exception: would be unfortunate! I think the PEP argues against this well 🙂

The == comparison also makes static typing very confusing: if we have BaseExceptionGroup -> ExceptionGroup -> MyEG and the last can also contain BaseExceptions, then either ExceptionGroup.exceptions must be annotated as able to contain BaseExceptions when it cannot, the annotations for MyEG must say it cannot when in fact it can, or we violate the substitution principle. This last is currently the case at runtime, but typecheckers are not keen on such things.

Hah! It looks like I just find this persistently startling: #28569 (comment) (but I promise, no PEP this time 😉)

Yeah, I definitely recall that we discussed this before. But looking at the code it's possible that we were too conservative. In particular in the fallback clause we could have chosen to check if cls is a subclass of PyExc_ExceptionGroup if nested_base_exceptions is set and raise the same error as on line 742.

The thing we definitely can't do is adjusting the class if it is exactly PyExc_BaseExceptionGroup and nested_base_exceptions is false.

The question is, can we treat this as a bug and fix it (in 3.11.1 if it isn't out yet) or would such a fix be considered backwards compatible?

I think we can call it a bug. It’s better to change it in 3.11.1 than in 3.12.

Sounds good.

pythongh-99553: fix bug where an ExceptionGroup subclass can wrap a B…

gh-99553: fix bug where an ExceptionGroup subclass can wrap a BaseExc…

pythongh-99553: fix bug where an ExceptionGroup subclass can wrap a B…

gh-99553: fix bug where an ExceptionGroup subclass can wrap a BaseExc…

pythongh-99553: clarify doc and add tests

gh-99553: add tests for ExceptionGroup wrapping (#99615)

pythongh-99553: add tests for ExceptionGroup wrapping (pythonGH-99615)

gh-99553: add tests for ExceptionGroup wrapping (GH-99615)

pythongh-99553: add tests for ExceptionGroup wrapping (python#99615)

Navigation Menu

Repository navigation

Subclasses of `ExceptionGroup` can wrap `BaseException`s #99553

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	if (cls == PyExc_ExceptionGroup) {
	if (nested_base_exceptions) {
	PyErr_SetString(PyExc_TypeError,
	"Cannot nest BaseExceptions in an ExceptionGroup");
	goto error;

Subclasses of ExceptionGroup can wrap BaseExceptions #99553

Description

Linked PRs

Activity

iritkatriel commented on Nov 17, 2022

Zac-HD commented on Nov 17, 2022

Zac-HD commented on Nov 17, 2022

gvanrossum commented on Nov 17, 2022

iritkatriel commented on Nov 17, 2022

gvanrossum commented on Nov 17, 2022

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

Subclasses of `ExceptionGroup` can wrap `BaseException`s #99553