Visitar URL original
Github action for making a new release · Issue #5 · python-lsp/python-lsp-black · GitHub
Skip to content

Github action for making a new release #5

Description

@haplo

Add a Github action that automates the release process as much as possible. Use mypy-ls's release action for inspiration.

Update RELEASE.md accordingly.

Activity

  1. self-assigned this
    on May 18, 2021
  2. haplo commented on Apr 12, 2022

    @haplo
    CollaboratorAuthor

    Should use a dedicated PyPI API token for the upload: https://pyfound.blogspot.com/2020/01/start-using-2fa-and-api-tokens-on-pypi.html

    twine seems to not support API tokens yet, but there is a workaround.

  3. removed their assignment
    on Apr 12, 2022
  4. peterrus commented on May 1, 2022

    @peterrus

    Hey @haplo, I might be interested in setting this up. How do we go about the token? I can imagine you not wanting to share that with a random stranger on the internet right now.

    Have you given this any thought?

    Maybe something like this: https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

  5. haplo commented on May 1, 2022

    @haplo
    CollaboratorAuthor

    Hi @peterrus, thank you for taking an interest on this task.

    It looks like Github Actions has secrets support, so that's what we should be using. I would create a PyPI API token limited only to this package, then add a PYPI_TOKEN secret (so it would be SECRET_PYPI_TOKEN when referenced from the Github Action) in the Github repository settings.

    I'm adding the secret now, let me know if you hit any issues with the action.

  6. haplo commented on May 1, 2022

    @haplo
    CollaboratorAuthor

    @ccordoba12 I think I might be lacking permissions to admin this repository. Would you review my access, or set up the PyPI token secret as described in my previous message?

  7. peterrus commented on May 1, 2022

    @peterrus

    Ok, I will monitor this and see if I can find some time soon to have a look at this!

  8. haplo commented on May 18, 2022

    @haplo
    CollaboratorAuthor

    Ping @ccordoba12, please see my above message. 🙏

  9. ccordoba12 commented on Sep 30, 2022

    @ccordoba12
    Member

    Hey @haplo, sorry for the delay in seeing your message. I just granted you admin permissions to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions