Repository navigation
Missing conftest.py in 3.0.3 source distribution #456
Description
Which version of Python is the problem with?
3.14, 3.13, 3.12, 3.11, 3.10
What semver version are you using?
3.0.3
What OS are you using? (Add more in the Environment section)
Linux
Situation
As a side effect of removing setuptools_scm, the 3.0.3 source distribution has lots a lot files:
-.coveragerc
-.editorconfig
-.gitignore
-.readthedocs.yaml
CHANGELOG.rst
-CITATION.cff
CONTRIBUTING.rst
-CONTRIBUTORS
LICENSE.txt
MANIFEST.in
-Makefile
PKG-INFO
README.rst
-SUPPORT.md
-changelog.d/
-changelog.d/.gitignore
-changelog.d/README.rst
-changelog.d/_template.rst
-docs/
[…]
pyproject.toml
-release-procedure.md
setup.cfg
src/
src/semver/
@@ -101,9 +24,6 @@ src/semver.egg-info/dependency_links.txt
src/semver.egg-info/entry_points.txt
src/semver.egg-info/top_level.txt
tests/
-tests/coerce.py
-tests/conftest.py
-tests/semverwithvprefix.py
tests/test_bump.py
tests/test_compare.py
tests/test_deprecated_functions.py
@@ -119,4 +39,3 @@ tests/test_replace.py
tests/test_semver.py
tests/test_subclass.py
tests/test_typeerror-274.py
-tox.iniSince tests/conftest.py is missing, running test suite now fails due to missing fixtures, e.g.:
_______________________________________ ERROR at setup of test_version_info_should_be_iterable ________________________________________
file /tmp/portage/dev-python/semver-3.0.3/work/semver-3.0.3/tests/test_semver.py, line 39
def test_version_info_should_be_iterable(version):
E fixture 'version' not foundI don't know whether the other .py files are actually needed for tests as well.
How to reproduce
wget https://files.pythonhosted.org/packages/13/f8/071c42ed3e9678f66a6d624c8df4cdd1490de2504dde6a1d47b61a8195e2/semver-3.0.3.tar.gz
tar -xf semver-3.0.3.tar.gz
cd semver-3.0.3
pip install -e . pytest
pytest
Expected behavior
All tests passing.
Environment
No response
Metadata
Metadata
Assignees
Labels
Type
Fields
SIze
None yet
Activity
tomschr commentedon Jan 20, 2025
Thank you for filing this issue. Seems the 3.0.3 version had some issues. Need to investigate it further.
RobPasMue commentedon Jan 20, 2025
Might be a good idea to yank the version in the meantime?
tomschr commentedon Jan 20, 2025
I yanked the version 3.0.3 on PyPI now, but not deleted the files as recommended by PyPI. You should see that now:
https://pypi.org/manage/project/semver/release/3.0.3/
You still can install them if you request
semver==3.0.3. I will release a new version soon.RobPasMue commentedon Jan 20, 2025
Awesome, thanks a lot!
Fix python-semver#456: Fix source dist file
Fix #456: Fix source dist file
tomschr commentedon Jan 20, 2025
@RobPasMue If you want to give it a try, look at PR #459. I combined the license issue and the source dist issue.
tomschr commentedon Jan 22, 2025
@mgorny Ok, I've tested it from https://test.pypi.org/project/semver/3.0.4.dev1/#files and used the commands from "How to reproduce".
Could you confirm so I could release 3.0.4? Thanks! 🎉
mgorny commentedon Jan 22, 2025
The
docs/tree seem to be missing. It's not a big deal, but it looks weird, give that e.g.changelog.dis present — and I don't think that one is really meaningful here.Outside of that, tests seem to work fine now.
Fix #456: Fix source dist file
tomschr commentedon Jan 22, 2025
Great, thanks! I've fixed that in 3.0.4.dev2. Find it at https://test.pypi.org/project/semver/3.0.4.dev2/#files.
mgorny commentedon Jan 23, 2025
Yeah, that looks good for our use. Thanks!
FWICS the only remaining meaningful differences are:
tomschr commentedon Jan 23, 2025
Aww, I missed these files. Thanks a lot! I've created 3.0.3-dev3 at https://test.pypi.org/project/semver/3.0.4.dev3/#files.
mgorny commentedon Jan 23, 2025
Ok, now we have 1:1 match (besides
.git*). Thanks!Fix #459: Fix 3.0.3
Fix #459: Fix 3.0.3
mgorny commentedon Jan 24, 2025
Thank you!